You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "JingGe (via GitHub)" <gi...@apache.org> on 2023/11/25 07:15:05 UTC
[PR] Develop archunit test for filesystem test code [flink]
JingGe opened a new pull request, #23798:
URL: https://github.com/apache/flink/pull/23798
## What is the purpose of the change
Develop archunit test for filesystem test code
## Verifying this change
This change are new archunit tests without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-26010] Develop archunit test for filesystem test code [flink]
Posted by "JingGe (via GitHub)" <gi...@apache.org>.
JingGe commented on code in PR #23798:
URL: https://github.com/apache/flink/pull/23798#discussion_r1407784916
##########
flink-filesystems/flink-azure-fs-hadoop/pom.xml:
##########
@@ -47,6 +47,14 @@ under the License.
<scope>provided</scope>
</dependency>
+ <!-- ArchUit test dependencies -->
Review Comment:
good catch! Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-26010] Develop archunit test for filesystem test code [flink]
Posted by "PatrickRen (via GitHub)" <gi...@apache.org>.
PatrickRen commented on code in PR #23798:
URL: https://github.com/apache/flink/pull/23798#discussion_r1407290209
##########
flink-filesystems/flink-azure-fs-hadoop/pom.xml:
##########
@@ -47,6 +47,14 @@ under the License.
<scope>provided</scope>
</dependency>
+ <!-- ArchUit test dependencies -->
Review Comment:
typo `ArchUnit`. Same issue in all poms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-26010] Develop archunit test for filesystem test code [flink]
Posted by "JingGe (via GitHub)" <gi...@apache.org>.
JingGe merged PR #23798:
URL: https://github.com/apache/flink/pull/23798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Develop archunit test for filesystem test code [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #23798:
URL: https://github.com/apache/flink/pull/23798#issuecomment-1826238749
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0d7a07427d32949181614138b1950da864930f1a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0d7a07427d32949181614138b1950da864930f1a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0d7a07427d32949181614138b1950da864930f1a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org