[GitHub] incubator-distributedlog pull request #75: DL-123: Every tests should have t...

[brennonyork <gi...@git.apache.org>]

GitHub user brennonyork opened a pull request:

    https://github.com/apache/incubator-distributedlog/pull/75

    DL-123: Every tests should have timeout

    * used a simple bash script to find any tests without a timeout
    
    Here is the below bash executed from the root directory. This could be expanded to take in more than one line above the initial `grep` although, for more, it only reduces the false positive rate. After this patch there are only 4 false positives (tests where the text immediately above is not `@Test(timeout = ...)`). 
    ```
    grep -r "public void test" -B 1 * | awk '($NR+1) % 3 !=0 {printf $0; printf " "} NR % 3 == 0 {print " "}' | grep -v "timeout"
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/brennonyork/incubator-distributedlog DL-123

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-distributedlog/pull/75.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #75
    
----
commit ece7cde25fd44e913d0b5b15a807fd1d0f28fd89
Author: Brennon York <br...@capitalone.com>
Date:   2016-12-16T05:06:29Z

    added timeout of 60000 to all tests

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-distributedlog issue #75: DL-123: Every tests should have timeout

[brennonyork <gi...@git.apache.org>]

Github user brennonyork commented on the issue:

    https://github.com/apache/incubator-distributedlog/pull/75
  
    Totally valid question. I went through and Google'd for a bit and found a few links. In short the best we can do that is _currently_ supported by JUnit is to create a class rule within a test suite (eg timeout) although we'd then need to create all the test suites (which it doesn't look like DL is setup for currently).
    
    * [history of global params for junit](https://github.com/junit-team/junit4/issues/1219)
    * [creating class rules for test suites](http://stackoverflow.com/questions/16608934/can-i-apply-a-time-limit-for-all-the-tests-in-the-suite) 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-distributedlog issue #75: DL-123: Every tests should have timeout

[leighst <gi...@git.apache.org>]

Github user leighst commented on the issue:

    https://github.com/apache/incubator-distributedlog/pull/75
  
    Makes sense, doesnt sound obviously better. Shipit!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-distributedlog pull request #75: DL-123: Every tests should have t...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-distributedlog/pull/75


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---