[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10315: [multistage] properly support query hint

["siddharthteotia (via GitHub)" <gi...@apache.org>]

siddharthteotia commented on code in PR #10315:
URL: https://github.com/apache/pinot/pull/10315#discussion_r1113940359


##########
pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotAggregateExchangeNodeInsertRule.java:
##########
@@ -83,8 +83,8 @@ public boolean matches(RelOptRuleCall call) {
     }
     if (call.rel(0) instanceof Aggregate) {
       Aggregate agg = call.rel(0);
-      return !agg.getHints().contains(PinotRelationalHints.AGG_LEAF_STAGE)
-          && !agg.getHints().contains(PinotRelationalHints.AGG_INTERMEDIATE_STAGE);
+      return !agg.getHints().contains(AggregateNode.INTERMEDIATE_STAGE_HINT)

Review Comment:
   > these 2 hints are not suppose to be directly used by user. 
   
   You both may have already discussed this but not sure I follow this. At least in the other PR, we want to create a hint and expose it to user. 
   
   Fair to say that if I want to add a new hint and expose it to the user, this will have to be evolved / extended or there is a different plan ?
   
   ```
   public static final HintStrategyTable PINOT_HINT_STRATEGY_TABLE = HintStrategyTable.builder()
         .hintStrategy(INTERNAL_AGG_INTERMEDIATE_STAGE, HintPredicates.AGGREGATE)
         .hintStrategy(INTERNAL_AGG_FINAL_STAGE, HintPredicates.AGGREGATE)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org