You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2019/07/17 11:04:24 UTC

[GitHub] [tinkerpop] spmallette commented on a change in pull request #1162: TINKERPOP-2265 Deprecate remote Traversal.sideEffects

spmallette commented on a change in pull request #1162: TINKERPOP-2265 Deprecate remote Traversal.sideEffects
URL: https://github.com/apache/tinkerpop/pull/1162#discussion_r304342773
 
 

 ##########
 File path: gremlin-dotnet/src/Gremlin.Net/Process/Traversal/ITraversalSideEffects.cs
 ##########
 @@ -29,6 +29,7 @@ namespace Gremlin.Net.Process.Traversal
     /// <summary>
     ///     A <see cref="ITraversal" /> can maintain global sideEffects.
     /// </summary>
+    [Obsolete("As of release 3.3.8, not replaced, prefer use of cap()-step to retrieve side-effects as part of traversal iteration")]
 
 Review comment:
   hmm - i think so. it's going to end up being a do-nothing interface ultimately. If we removed `ITraversal.SideEffects` then it wouldn't serve much purpose. We don't do any local side-effects, so without remote ones it doesn't seem useful. Unless we just keep it around for API completeness to match Java?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services