You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by techmaniack <gi...@git.apache.org> on 2016/06/03 10:22:39 UTC
[GitHub] flink pull request #2066: Updated ssh configuration in base Dockerfile
GitHub user techmaniack opened a pull request:
https://github.com/apache/flink/pull/2066
Updated ssh configuration in base Dockerfile
- The pull request addresses only one issue
Won't allow ssh into the container as 'without-password' is now replaced with 'prohibit-password' in Xenial.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/techmaniack/flink patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2066.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2066
----
commit 768723ccf9cf2cab09905063cbf5f7ddf4296494
Author: AbdulKarim Memon <ab...@gmail.com>
Date: 2016-06-03T10:20:51Z
Updated ssh configuration in base Dockerfile
Won't allow ssh into the container as 'without-password' is now replaced with 'prohibit-password' in Xenial.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2066: Updated ssh configuration in base Dockerfile
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2066
Is there a JIRA ticket for this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2066: Updated ssh configuration in base Dockerfile
Posted by techmaniack <gi...@git.apache.org>.
Github user techmaniack commented on a diff in the pull request:
https://github.com/apache/flink/pull/2066#discussion_r65873361
--- Diff: flink-contrib/docker-flink/base/Dockerfile ---
@@ -38,12 +38,12 @@ ENV JAVA_HOME /usr/java/default/
RUN echo 'root:secret' | chpasswd
#SSH as root... probably needs to be revised for security!
-RUN sed -i 's/PermitRootLogin without-password/PermitRootLogin yes/' /etc/ssh/sshd_config
--- End diff --
Agreed. It might break previous ubuntu versions workflow.
Changing the sed expression to the following works for precise/trusty/xenial
`sed -i 's/PermitRootLogin .*/PermitRootLogin yes/' /etc/ssh/sshd_config`
Also, currently the flink version is hardcoded in a URL in flink/Dockerfile which can be moved to **install-flink.sh** where flink/scala/hadoop versions can be specified. Something like this:
```
BASE_URL=http://www-us.apache.org/dist/flink/
FLINK_VERSION=1.0.3
SCALA_VERSION=2.11
HADOOP_VERSION=27 #2.7.0
FULL_URL="$BASE_URL/flink-$FLINK_VERSION/flink-$FLINK_VERSION-bin-hadoop$HADOOP_VERSION-scala_$SCALA_VERSION.tgz"
wget -q -O - $FULL_URL | tar -zxvf - -C /usr/local/
cd /usr/local && ln -s "./flink-$FLINK_VERSION" flink
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2066: Updated ssh configuration in base Dockerfile
Posted by techmaniack <gi...@git.apache.org>.
Github user techmaniack commented on the issue:
https://github.com/apache/flink/pull/2066
@greghogan +1 to close
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2066: Updated ssh configuration in base Dockerfile
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2066#discussion_r65825673
--- Diff: flink-contrib/docker-flink/base/Dockerfile ---
@@ -38,12 +38,12 @@ ENV JAVA_HOME /usr/java/default/
RUN echo 'root:secret' | chpasswd
#SSH as root... probably needs to be revised for security!
-RUN sed -i 's/PermitRootLogin without-password/PermitRootLogin yes/' /etc/ssh/sshd_config
--- End diff --
+1 to Greg's suggestion. Otherwise users of old versions will have a problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2066: Updated ssh configuration in base Dockerfile
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2066
+1 to close this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2066: Updated ssh configuration in base Dockerfile
Posted by techmaniack <gi...@git.apache.org>.
Github user techmaniack closed the pull request at:
https://github.com/apache/flink/pull/2066
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2066: Updated ssh configuration in base Dockerfile
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2066
The `Dockerfile` has been fully rewritten since this PR. @techmaniack is there additional functionality still needed or can this PR be closed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2066: Updated ssh configuration in base Dockerfile
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2066#discussion_r65717466
--- Diff: flink-contrib/docker-flink/base/Dockerfile ---
@@ -38,12 +38,12 @@ ENV JAVA_HOME /usr/java/default/
RUN echo 'root:secret' | chpasswd
#SSH as root... probably needs to be revised for security!
-RUN sed -i 's/PermitRootLogin without-password/PermitRootLogin yes/' /etc/ssh/sshd_config
--- End diff --
Can this be handled more flexibly using sed regular expressions such that any parameter is changed to `yes`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---