[GitHub] [cassandra] dcapwell commented on a change in pull request #828: Make relocate dependencies script less manual

[GitBox <gi...@apache.org>]

dcapwell commented on a change in pull request #828:
URL: https://github.com/apache/cassandra/pull/828#discussion_r527155511



##########
File path: build-shaded-dtest-jar.sh
##########
@@ -2,12 +2,17 @@
 
 set -xe
 
-# Cassandra version that is specified in build.xml
-CASSANDRA_VERSION=$1
-# In-JVM dtest version that is specified in relocate-dependencies.pom
-DTEST_VERSION=$2
+cp .//build/lib/jars/reflections-0.9.12.jar ./lib
+cp .//build/lib/jars/javassist-3.26.0-GA.jar ./lib
+
 ARTIFACT_NAME=cassandra-dtest
 REPO_DIR=~/.m2/repository
+CASSANDRA_VERSION=$(cat build.xml | grep 'property name="base.version"' | awk -F "\"" '{print $4}')
+DTEST_VERSION=$(cat relocate-dependencies.pom | grep "dtest-local.version>" | awk -F "\>|\<" '{print $3}')

Review comment:
       how are we expected to manage this version?  it seems decoupled from CASSANDRA-VERSION and doesn't actually show the dtest-api version; should we not just have this match the CASSANDRA_VERSIOn?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org