You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tzulitai <gi...@git.apache.org> on 2017/01/20 18:29:29 UTC
[GitHub] flink pull request #3185: [FLINK-5375] [doc] Fix Watermark Semantics
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3185
[FLINK-5375] [doc] Fix Watermark Semantics
Fix watermark semantics in documenation to be correctly aligned with implementation: a Watermark _t_ declares that event time has reached time _t_ in that stream, meaning that there should be no more elements from the stream with a timestamp **t' <= t** (i.e. events with timestamps older or equal to the watermark).
Also proof-read and corrected some mistakes in event-time / watermark related docs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tzulitai/flink FLINK-5375
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3185.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3185
----
commit a9469b982f58a37f395fb53fc7b762b557437e4f
Author: Tzu-Li (Gordon) Tai <tz...@apache.org>
Date: 2017-01-20T18:12:27Z
[FLINK-5375] [doc] Fix Watermark Semantics
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3185: [FLINK-5375] [doc] Fix watermark semantics in documentati...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3185
@aljoscha thank you for the review. I'll address the inline comment and merge this to `master` and `release-1.2`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3185: [FLINK-5375] [doc] Fix watermark semantics in docu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3185
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3185: [FLINK-5375] [doc] Fix watermark semantics in docu...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3185#discussion_r97507114
--- Diff: docs/dev/event_time.md ---
@@ -142,7 +143,7 @@ to use timestamp assignment and watermark generation in the Flink DataStream API
# Event Time and Watermarks
-*Note: Flink implements many techniques from the Dataflow Model. For a good introduction to Event Time and, have also a look at these articles*
+*Note: Flink implements many techniques from the Dataflow Model. For a good introduction to Event Time and Watermarks, have also a look at these articles -*
--- End diff --
Is there a superfluous dash at the end?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---