[GitHub] [storm] Ethanlm commented on pull request #3363: STORM-3724 use blobstore modtime to prevent querying each remote file on update

[GitBox <gi...@apache.org>]

Ethanlm commented on pull request #3363:
URL: https://github.com/apache/storm/pull/3363#issuecomment-758152578


   I thought modification meant any changes to the blobs including add/update/delete. But if it doesn't, I still see two different behaviors from the current code regarding deletion:
   
   If the `bucketDir` is empty after deletion, this deletion is ignored and supervisors are not notified;
   if the `bucketDir` is not empty after deletion, this deletion will update the remoteLastModTime and supervisors will be notified. 
   
   So modification here sometimes include "deletion", sometimes doesn't. I would love it to be more consistent. 
   
   Please correct me if I misunderstand anything. Thanks.
   
   Also, what will happen if a blob is deleted by `blobstore delete` command? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org