You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2023/01/11 14:21:07 UTC

[GitHub] [inlong] shink opened a new pull request, #7219: [INLONG-7218][CI] Add Windows support on GitHub Actions

shink opened a new pull request, #7219:
URL: https://github.com/apache/inlong/pull/7219

   Fixes #7218
   
   ### Motivation
   
   We can use `jobs.<job_id>.runs-on` to define the type of machine to run the job on.
   
   See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idruns-on
   
   ### Modifications
   
   Add Windows support on GitHub Actions when building and testing InLong.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] shink commented on pull request #7219: [INLONG-7218][CI] Add Windows and MacOS support on GitHub Actions

Posted by GitBox <gi...@apache.org>.
shink commented on PR #7219:
URL: https://github.com/apache/inlong/pull/7219#issuecomment-1385443926

   @dockerzhang PTAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] dockerzhang commented on pull request #7219: [INLONG-7218][CI] Add Windows and MacOS support on GitHub Actions

Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang commented on PR #7219:
URL: https://github.com/apache/inlong/pull/7219#issuecomment-1407543364

   @shink, the CI workflow run failed for windows os. Please fix it.
   ![image](https://user-images.githubusercontent.com/18047329/215301436-912f46fd-4484-4bf4-987f-df8c2606a0c3.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] dockerzhang commented on pull request #7219: [INLONG-7218][CI] Add Windows support on GitHub Actions

Posted by GitBox <gi...@apache.org>.
dockerzhang commented on PR #7219:
URL: https://github.com/apache/inlong/pull/7219#issuecomment-1379700077

   @shink it's better to add the action for MacOS. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] dockerzhang closed pull request #7219: [INLONG-7218][CI] Add Windows and MacOS support on GitHub Actions

Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang closed pull request #7219: [INLONG-7218][CI] Add Windows and MacOS support on GitHub Actions
URL: https://github.com/apache/inlong/pull/7219


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] github-actions[bot] commented on pull request #7219: [INLONG-7218][CI] Add Windows and MacOS support on GitHub Actions

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7219:
URL: https://github.com/apache/inlong/pull/7219#issuecomment-1514024723

   This PR is stale because it has been open for 60 days with no activity.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] shink commented on pull request #7219: [INLONG-7218][CI] Add Windows and MacOS support on GitHub Actions

Posted by "shink (via GitHub)" <gi...@apache.org>.
shink commented on PR #7219:
URL: https://github.com/apache/inlong/pull/7219#issuecomment-1419096314

   @dockerzhang
   
   It seems that there are some codes that do not support cross-platform.
   
   See https://github.com/shink/inlong/actions/runs/4097168091/jobs/7065344093#step:6:2138
   
   ```
   File.separator is used as a regex; will not work on Windows.
   ```
   ![image](https://user-images.githubusercontent.com/49934421/216984772-1c7d5e6f-c842-4a8a-b54e-644a6ba6d83d.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] shink commented on pull request #7219: [INLONG-7218][CI] Add Windows support on GitHub Actions

Posted by GitBox <gi...@apache.org>.
shink commented on PR #7219:
URL: https://github.com/apache/inlong/pull/7219#issuecomment-1378836908

   @dockerzhang Windows, Linux and MacOS are all available GitHub-hosted runner types. Should we support MacOS on GitHub Actions?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] github-actions[bot] commented on pull request #7219: [INLONG-7218][CI] Add Windows and MacOS support on GitHub Actions

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7219:
URL: https://github.com/apache/inlong/pull/7219#issuecomment-1598008385

   This PR is stale because it has been open for 60 days with no activity.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] shink commented on pull request #7219: [INLONG-7218][CI] Add Windows and MacOS support on GitHub Actions

Posted by "shink (via GitHub)" <gi...@apache.org>.
shink commented on PR #7219:
URL: https://github.com/apache/inlong/pull/7219#issuecomment-1434660574

   @dockerzhang PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org