You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2019/08/15 05:20:40 UTC

[GitHub] [helix] narendly commented on issue #410: Fix the execution delay for the jobs (409)

narendly commented on issue #410: Fix the execution delay for the jobs (409)
URL: https://github.com/apache/helix/pull/410#issuecomment-521517395
 
 
   A comment on the test you added. I had a hard time understanding what you're trying to test in your test. I think we could make the test more robust by adding a more intuitive test case, and also add some description in your test so that anyone could see what you're doing clearly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org