You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by David Kimdon <da...@kimdon.org> on 2004/02/07 14:36:30 UTC
[PATCH] : make svnshell errors less confusing
Hi,
This patch came to me by way of Roland Illig and the Debian BTS :
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=230534
I think it would be a welcome addition to Subversion. Any seconds?
-David
* tools/examples/svnshell.py : Make the error messages that svnshell
emits for unknown commands less confusing.
Roland Illig <ro...@gmx.de>.
Index: upstream/tools/examples/svnshell.py
===================================================================
--- upstream.orig/tools/examples/svnshell.py 2003-12-29 18:51:28.000000000 +0100
+++ upstream/tools/examples/svnshell.py 2004-02-07 15:16:31.964080873 +0100
@@ -45,14 +45,8 @@
def postcmd(self, stop, line):
self._setup_prompt()
- _errors = ["Huh?",
- "Whatchoo talkin' 'bout, Willis?",
- "Say what?",
- "Nope. Not gonna do it.",
- "Ehh...I don't think so, chief."]
-
def default(self, line):
- print self._errors[randint(0, len(self._errors) - 1)]
+ print "Unknown command."
def do_cat(self, arg):
"""dump the contents of a file"""
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] : make svnshell errors less confusing
Posted by David Kimdon <da...@kimdon.org>.
On Mon, Feb 09, 2004 at 03:59:12PM -0600, Ben Collins-Sussman wrote:
> My impression is that mailer.py is more featureful and much more
> "maintained" than commit-email.pl. You might want to change your
> policy, or include both.
oops, actually, as Florian Weimer just pointed out to me, I already
include both. Move on, nothing to see here . . .
-David
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] : make svnshell errors less confusing
Posted by Ben Collins-Sussman <su...@collab.net>.
On Mon, 2004-02-09 at 15:38, David Kimdon wrote:
> hmm, well, I don't include mailer.py, but instead include
> commit-email.pl, for no particular reason.
My impression is that mailer.py is more featureful and much more
"maintained" than commit-email.pl. You might want to change your
policy, or include both.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] : make svnshell errors less confusing
Posted by David Kimdon <da...@kimdon.org>.
On Mon, Feb 09, 2004 at 03:26:35PM -0600, C. Michael Pilato wrote:
> David Kimdon <da...@kimdon.org> writes:
>
> > Oh, don't get me wrong. I never said it wasn't funny, or cute. In
> > fact it is (both funny and cute). The problem though is when the
> > humor gets lost and leads to confusion. I would imagine someone whose
> > mother tongue is not English could have trouble (anyone feel free to
> > correct me if I am wrong, but the messages look pretty idiomatic to
> > me). I can't in good conscience include the tool in the Debian package
> > as it is for this reason. Perhaps it shouldn't be included in the
> > package anyway, since it is just an example.
>
> Just don't include it. mailer.py is all the example anyone will need
> to get an idea of how to use the filesystem interface via the
> bindings.
hmm, well, I don't include mailer.py, but instead include
commit-email.pl, for no particular reason. I'll remove svnshell from
the package. Anyone wanting to use the bindings will probably grab
the whole source and poke around anyway.
Thanks for the advice,
David
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] : make svnshell errors less confusing
Posted by "C. Michael Pilato" <cm...@collab.net>.
David Kimdon <da...@kimdon.org> writes:
> Oh, don't get me wrong. I never said it wasn't funny, or cute. In
> fact it is (both funny and cute). The problem though is when the
> humor gets lost and leads to confusion. I would imagine someone whose
> mother tongue is not English could have trouble (anyone feel free to
> correct me if I am wrong, but the messages look pretty idiomatic to
> me). I can't in good conscience include the tool in the Debian package
> as it is for this reason. Perhaps it shouldn't be included in the
> package anyway, since it is just an example.
Just don't include it. mailer.py is all the example anyone will need
to get an idea of how to use the filesystem interface via the
bindings.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] : make svnshell errors less confusing
Posted by David Kimdon <da...@kimdon.org>.
On Sat, Feb 07, 2004 at 12:57:35PM -0500, Eric Gillespie wrote:
> David Kimdon <da...@kimdon.org> writes:
>
> > I think it would be a welcome addition to Subversion. Any seconds?
>
> -0
>
> It's an example. Have a sense of humor, please.
Oh, don't get me wrong. I never said it wasn't funny, or cute. In
fact it is (both funny and cute). The problem though is when the
humor gets lost and leads to confusion. I would imagine someone whose
mother tongue is not English could have trouble (anyone feel free to
correct me if I am wrong, but the messages look pretty idiomatic to
me). I can't in good conscience include the tool in the Debian package
as it is for this reason. Perhaps it shouldn't be included in the
package anyway, since it is just an example.
-David
>
> --
> Eric Gillespie <*> epg@pretzelnet.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] : make svnshell errors less confusing
Posted by Eric Gillespie <ep...@pretzelnet.org>.
David Kimdon <da...@kimdon.org> writes:
> I think it would be a welcome addition to Subversion. Any seconds?
-0
It's an example. Have a sense of humor, please.
--
Eric Gillespie <*> epg@pretzelnet.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org