[jira] [Commented] (CONNECTORS-1462) Add support for rootPath attribute in File System Connector repository

["Karl Wright (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CONNECTORS-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16186335#comment-16186335 ] 

Karl Wright commented on CONNECTORS-1462:
-----------------------------------------

Hi [~lcabaceira], first off, the way you attach patches is by the following process:

(1) Make changes in your local svn work area
(2) At the root level of that work area, do "svn diff >CONNECTORS-1462.patch", or whatever makes sense
(3) Attach the generated file as a file to the ticket, under "More->Attach files"

Second, the code you have generated concatenates all path specifications together.  You won't be able to work with that; it will only work if there is one such path specification.  Instead, you will need to use each document's MCF identifier and match it against the source paths that exist in the specification to find the right one.

Thanks!


> Add support for rootPath attribute in File System Connector repository
> ----------------------------------------------------------------------
>
>                 Key: CONNECTORS-1462
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-1462
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Alfresco BFSI Output Connector, File system connector
>    Affects Versions: ManifoldCF 2.9
>            Reporter: Luis Cabaceira
>            Assignee: Piergiorgio Lucidi
>              Labels: patch
>             Fix For: ManifoldCF next
>
>         Attachments: FileConnector.java
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> In recent conversations about specific needs of the new output connectors (in this case for the Alfresco BFSI Output connector) a new construct was added in RepositoryDocument to support having a rootPath attribute under the document object. This new construct exists currently only in CONNECTORS-1356-2.7.1 branch.
> This issue addresses the changes necessary to the File System Connector to support the new construct and inject the rootPath locations into RepositoryDocument.
> ------------
> Changes 
> ------------
> org.apache.manifoldcf.crawler.connectors.filesystem.FileConnector.java 
>   
> {code:java}
>   // Extract rootPath from the specification
>     ArrayList<String> rootPath = new ArrayList<String>();
>     for (int i = 0; i < spec.getChildCount(); i++)
>     {
>       SpecificationNode sn = spec.getChild(i);
>       if (sn.getType().equals("startpoint"))
>       {
>         String path = sn.getAttributeValue("path").replaceAll("\\\\","/");
>         if (path.length() > 0)
>         {
>           if (!path.endsWith("/")) path += "/";
>           rootPath.add(path);
>           break;
>         }
>       }
>     }
> {code}
> ...
> {code:java}
>         RepositoryDocument data = new RepositoryDocument();
>         data.setFileName(fileName);
>         data.setMimeType(mimeType);
>         data.setModifiedDate(modifiedDate);
>         data.setRootPath(rootPath); // Adding the rootPath to RepositoryDocument
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)