You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "warren830 (via GitHub)" <gi...@apache.org> on 2023/02/08 07:47:10 UTC

[GitHub] [incubator-devlake] warren830 opened a new pull request, #4358: feat(sonarqube): add hotspot convertor

warren830 opened a new pull request, #4358:
URL: https://github.com/apache/incubator-devlake/pull/4358

   ### Summary
   add hotspot convertor
   
   ### Does this close any open issues?
   part of #2305 
   
   ### Screenshots
   ![image](https://user-images.githubusercontent.com/39366025/217466416-437a337c-3937-4614-8e62-7a7f460e5ca2.png)
   
   
   ### Other Information
   Any other information that is important to this PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] abeizn commented on a diff in pull request #4358: feat(sonarqube): add hotspot convertor

Posted by "abeizn (via GitHub)" <gi...@apache.org>.
abeizn commented on code in PR #4358:
URL: https://github.com/apache/incubator-devlake/pull/4358#discussion_r1099767827


##########
backend/plugins/sonarqube/models/migrationscripts/archived/sonarqube_hotspot.go:
##########
@@ -24,7 +24,7 @@ import (
 
 type SonarqubeHotspot struct {
 	ConnectionId             uint64           `gorm:"primaryKey"`
-	IssueKey                 string           `json:"key" gorm:"primaryKey"`
+	Key                      string           `json:"key" gorm:"primaryKey"`

Review Comment:
   Key or IssueKey?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] abeizn merged pull request #4358: feat(sonarqube): add hotspot convertor

Posted by "abeizn (via GitHub)" <gi...@apache.org>.
abeizn merged PR #4358:
URL: https://github.com/apache/incubator-devlake/pull/4358


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org