You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org> on 2025/04/24 12:32:08 UTC

[PR] [core] RestCatalog: support query options in listTables/listViews [paimon]

XiaoHongbo-Hope opened a new pull request, #5530:
URL: https://github.com/apache/paimon/pull/5530

   <!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
   
   ### Purpose
   support query options in listTables/listViews
   
   <!-- Linking this pull request to the issue -->
   
   
   <!-- What is the purpose of the change -->
   
   ### Tests
   RESTCatalogTest
   <!-- List UT and IT cases to verify this change -->
   
   ### API and Format
   rest-catalog-open-api.yaml
   <!-- Does this change affect API or storage format -->
   
   ### Documentation
   
   <!-- Does this change introduce a new feature -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [core] RestCatalog: support ListObjectsByPattern [paimon]

Posted by "sundapeng (via GitHub)" <gi...@apache.org>.
sundapeng commented on code in PR #5530:
URL: https://github.com/apache/paimon/pull/5530#discussion_r2063018504


##########
paimon-core/src/main/java/org/apache/paimon/rest/RESTCatalog.java:
##########
@@ -335,13 +344,18 @@ public PagedList<String> listTablesPaged(
 
     @Override
     public PagedList<Table> listTableDetailsPaged(
-            String db, @Nullable Integer maxResults, @Nullable String pageToken)
+            String db,
+            @Nullable Integer maxResults,
+            @Nullable String pageToken,
+            @Nullable String tableNamePattern)
             throws DatabaseNotExistException {
+        RESTUtil.validatePrefixSqlPattern(tableNamePattern);

Review Comment:
   The limitation should be checked at server side.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [core] RestCatalog: support ListObjectsByPattern [paimon]

Posted by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org>.
XiaoHongbo-Hope commented on PR #5530:
URL: https://github.com/apache/paimon/pull/5530#issuecomment-2835104953

   > Looks good to me!
   > 
   > You can do more integration tests.
   
   sure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [core] RestCatalog: support query options in listTables/listViews [paimon]

Posted by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org>.
XiaoHongbo-Hope commented on PR #5530:
URL: https://github.com/apache/paimon/pull/5530#issuecomment-2830196730

   > Can you explain what queryOptions are? What is the example?
   sure, still needs some research for this PR, mark it as draft temporarily.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [core] RestCatalog: support query options in listTables/listViews [paimon]

Posted by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org>.
XiaoHongbo-Hope commented on PR #5530:
URL: https://github.com/apache/paimon/pull/5530#issuecomment-2831791983

   > Can you explain what queryOptions are? What is the example?
   
   
   sure, still needs some research for this PR, mark it as draft temporarily.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [core] RestCatalog: support ListObjectsByPattern [paimon]

Posted by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org>.
XiaoHongbo-Hope commented on code in PR #5530:
URL: https://github.com/apache/paimon/pull/5530#discussion_r2063085340


##########
paimon-core/src/main/java/org/apache/paimon/rest/RESTCatalog.java:
##########
@@ -335,13 +344,18 @@ public PagedList<String> listTablesPaged(
 
     @Override
     public PagedList<Table> listTableDetailsPaged(
-            String db, @Nullable Integer maxResults, @Nullable String pageToken)
+            String db,
+            @Nullable Integer maxResults,
+            @Nullable String pageToken,
+            @Nullable String tableNamePattern)
             throws DatabaseNotExistException {
+        RESTUtil.validatePrefixSqlPattern(tableNamePattern);

Review Comment:
   ok 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [core] RestCatalog: support ListObjectsByPattern [paimon]

Posted by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org>.
XiaoHongbo-Hope commented on code in PR #5530:
URL: https://github.com/apache/paimon/pull/5530#discussion_r2063226096


##########
paimon-core/src/main/java/org/apache/paimon/rest/RESTCatalog.java:
##########
@@ -335,13 +344,18 @@ public PagedList<String> listTablesPaged(
 
     @Override
     public PagedList<Table> listTableDetailsPaged(
-            String db, @Nullable Integer maxResults, @Nullable String pageToken)
+            String db,
+            @Nullable Integer maxResults,
+            @Nullable String pageToken,
+            @Nullable String tableNamePattern)
             throws DatabaseNotExistException {
+        RESTUtil.validatePrefixSqlPattern(tableNamePattern);

Review Comment:
   > The limitation should be checked at server side.
   
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [core] RestCatalog: support query options in listTables/listViews [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #5530:
URL: https://github.com/apache/paimon/pull/5530#issuecomment-2829540246

   Can you explain what queryOptions are? What is the example?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [core] RestCatalog: support ListObjectsByPattern [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #5530:
URL: https://github.com/apache/paimon/pull/5530


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org