You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Claus Ibsen (JIRA)" <ji...@apache.org> on 2011/05/06 10:15:03 UTC

[jira] [Created] (CAMEL-3949) Sending a message to log endpoint should not convert payload to StreamCache

Sending a message to log endpoint should not convert payload to StreamCache
---------------------------------------------------------------------------

                 Key: CAMEL-3949
                 URL: https://issues.apache.org/jira/browse/CAMEL-3949
             Project: Camel
          Issue Type: Improvement
          Components: camel-core
    Affects Versions: 2.7.0
            Reporter: Claus Ibsen
            Assignee: Claus Ibsen
            Priority: Minor
             Fix For: 2.8.0


We should not automatic try to convert the payload to a StreamCache if you send a message to a log endpoint.

{code}
        StreamCache newBody = message.getBody(StreamCache.class);
        if (newBody != null) {
            message.setBody(newBody);
        }
{code}

Only if people have explicit enabled stream cache we can safely log it.
Otherwise we should not output streams in the log.

We should use the extractBodyForLogging from MessageHelper instead which cater for this.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (CAMEL-3949) Sending a message to log endpoint should not convert payload to StreamCache

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen resolved CAMEL-3949.
--------------------------------

    Resolution: Fixed

> Sending a message to log endpoint should not convert payload to StreamCache
> ---------------------------------------------------------------------------
>
>                 Key: CAMEL-3949
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3949
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.7.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>            Priority: Minor
>             Fix For: 2.8.0
>
>
> We should not automatic try to convert the payload to a StreamCache if you send a message to a log endpoint.
> {code}
>         StreamCache newBody = message.getBody(StreamCache.class);
>         if (newBody != null) {
>             message.setBody(newBody);
>         }
> {code}
> Only if people have explicit enabled stream cache we can safely log it.
> Otherwise we should not output streams in the log.
> We should use the extractBodyForLogging from MessageHelper instead which cater for this.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CAMEL-3949) Sending a message to log endpoint should not convert payload to StreamCache

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029886#comment-13029886 ] 

Claus Ibsen commented on CAMEL-3949:
------------------------------------

There is a new showStreams option on log component if you want to show the streams anyway.

> Sending a message to log endpoint should not convert payload to StreamCache
> ---------------------------------------------------------------------------
>
>                 Key: CAMEL-3949
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3949
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.7.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>            Priority: Minor
>             Fix For: 2.8.0
>
>
> We should not automatic try to convert the payload to a StreamCache if you send a message to a log endpoint.
> {code}
>         StreamCache newBody = message.getBody(StreamCache.class);
>         if (newBody != null) {
>             message.setBody(newBody);
>         }
> {code}
> Only if people have explicit enabled stream cache we can safely log it.
> Otherwise we should not output streams in the log.
> We should use the extractBodyForLogging from MessageHelper instead which cater for this.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira