[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #705: [IOTDB-396] New query clause: disable align

[GitBox <gi...@apache.org>]

HTHou commented on a change in pull request #705: [IOTDB-396] New query clause: disable align
URL: https://github.com/apache/incubator-iotdb/pull/705#discussion_r364206135
 
 

 ##########
 File path: server/src/main/java/org/apache/iotdb/db/query/dataset/NewEngineDataSetWithoutValueFilter.java
 ##########
 @@ -327,6 +328,167 @@ public TSQueryDataSet fillBuffer(int fetchSize, WatermarkEncoder encoder) throws
 
     return tsQueryDataSet;
   }
+  
+  /**
+   * for RPC in RawData query between client and server
+   * fill time buffer, value buffers and bitmap buffers
+   */
+  public TSQueryNonAlignDataSet fillNonAlignBuffer(int fetchSize, WatermarkEncoder encoder) throws IOException, InterruptedException {
 
 Review comment:
   May I ask what object will be in the blocking queue in this scenario? In each single read task, we get batch data from reader and transfer to bytebuffer. And then?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services