You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2013/04/05 21:08:02 UTC
[Bug 54808] New: Add numberOfVersionsToKeep when undeployOldVersions
is set to true
https://issues.apache.org/bugzilla/show_bug.cgi?id=54808
Bug ID: 54808
Summary: Add numberOfVersionsToKeep when undeployOldVersions is
set to true
Product: Tomcat 7
Version: trunk
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P2
Component: Catalina
Assignee: dev@tomcat.apache.org
Reporter: mcintoshj@gmail.com
Classification: Unclassified
Created attachment 30159
--> https://issues.apache.org/bugzilla/attachment.cgi?id=30159&action=edit
Patch to add number of versions attribute
Sample patch (still somewhat rough, no translations yet) to add the ability to
keep a certain number of prior versions.
This also adds a bit more logging of when undeployOldVersions is true and
what's going on.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 54808] Add numberOfVersionsToKeep when undeployOldVersions is
set to true
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54808
Jason McIntosh <mc...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mcintoshj@gmail.com
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 54808] Add numberOfVersionsToKeep when undeployOldVersions is
set to true
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54808
Konstantin Kolinko <kn...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #30159|0 |1
is patch| |
Attachment #30159|application/octet-stream |text/plain
mime type| |
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 54808] Add numberOfVersionsToKeep when undeployOldVersions is
set to true
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54808
--- Comment #2 from Mark Thomas <ma...@apache.org> ---
I'm not convinced of the usefulness of this feature.
The stated purpose is fall-back. Consider an application on version 1 and
version 2 is deployed. If a system admin wants the ability to fall-back to
version 1 if problems are noticed with version 2:
- With this option implemented, falling back would require deleting version 2
which will break the session for every user currently using version 2. That may
not be the desired behaviour.
- Once version 2 is considered stable version 1 would need to be manually
removed. This makes the undeployOldVersions feature unnecessary which in turn
makes this feature unnecessary.
Users wanting the ability to fall-back to version 1 after version 2 has been
deployed would be better following a different process:
- leave undeployOldVersions="true"
- deploy version 2
- if fall back is required
- deploy a copy of version 1 labelled as version 3
- delete version 2 if it is necessary to force users of version 2
I'd be happy to commit this new feature if there is a use case that cannot
easily be met by the current features but fallback does not appear to be it.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 54808] Add numberOfVersionsToKeep when undeployOldVersions is
set to true
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54808
Jason McIntosh <mc...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #30159|0 |1
is obsolete| |
--- Comment #1 from Jason McIntosh <mc...@gmail.com> ---
Created attachment 30198
--> https://issues.apache.org/bugzilla/attachment.cgi?id=30198&action=edit
Updated patch with a few fixes, cleaned up tabs
Some more cleanup to remove tabs and instead use whitespace, added JMX
references.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 54808] Add numberOfVersionsToKeep when undeployOldVersions is
set to true
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54808
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |WONTFIX
--- Comment #3 from Mark Thomas <ma...@apache.org> ---
It has been a month without any further feedback so I am resolving this as
WONTFIX.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org