You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/13 10:38:03 UTC
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15906: [fix](struct-type) fix some errors in data type factory create struct type
github-actions[bot] commented on code in PR #15906:
URL: https://github.com/apache/doris/pull/15906#discussion_r1069223514
##########
be/src/vec/data_types/data_type_factory.cpp:
##########
@@ -64,7 +64,7 @@
names.reserve(col_size);
for (size_t i = 0; i < col_size; i++) {
dataTypes.push_back(create_data_type(col_desc.get_sub_column(i)));
- names.push_back(col_desc.name());
+ names.push_back(col_desc.get_sub_field(i).name());
Review Comment:
warning: no member named 'get_sub_field' in 'doris::TabletColumn' [clang-diagnostic-error]
```cpp
names.push_back(col_desc.get_sub_field(i).name());
^
```
##########
be/src/vec/data_types/data_type_factory.cpp:
##########
@@ -36,7 +36,7 @@ DataTypePtr DataTypeFactory::create_data_type(const doris::Field& col_desc) {
names.reserve(field_size);
for (size_t i = 0; i < field_size; i++) {
dataTypes.push_back(create_data_type(*col_desc.get_sub_field(i)));
- names.push_back(col_desc.name());
+ names.push_back(col_desc.get_sub_field(i).name());
Review Comment:
warning: member reference type 'doris::Field *' is a pointer; did you mean to use '->'? [clang-diagnostic-error]
```suggestion
names.push_back(col_desc.get_sub_field(i)->name());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org