You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by gaohoward <gi...@git.apache.org> on 2016/06/17 06:49:29 UTC
[GitHub] activemq-artemis pull request #581: ARTEMIS-571 Fix issues in openwire tests...
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/581
ARTEMIS-571 Fix issues in openwire testsuite
* Redelivery count fix
* Regression in BrokerTest
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gaohoward/activemq-artemis master-openwire2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/581.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #581
----
commit e6c6aaefc95a819c355b134ba6224c5b19779d8c
Author: Howard Gao <ho...@gmail.com>
Date: 2016-06-17T02:49:01Z
ARTEMIS-571 Fix issues in openwire testsuite
* Redelivery count fix
* Regression in BrokerTest
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #581: ARTEMIS-571 Fix issues in openwire testsuite
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/581
I'm running tests..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #581: ARTEMIS-571 Fix issues in openwire tests...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/581
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #581: ARTEMIS-571 Fix issues in openwire tests...
Posted by gaohoward <gi...@git.apache.org>.
Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/581#discussion_r67630013
--- Diff: tests/activemq5-unit-tests/src/test/java/org/apache/activemq/ZeroPrefetchConsumerTest.java ---
@@ -157,9 +157,9 @@ public void testTwoConsumers() throws Exception {
// now lets receive it
MessageConsumer consumer1 = session.createConsumer(queue);
MessageConsumer consumer2 = session.createConsumer(queue);
- TextMessage answer = (TextMessage) consumer1.receiveNoWait();
+ TextMessage answer = (TextMessage) consumer1.receive(5000);
assertEquals("Should have received a message!", answer.getText(), "Msg1");
- answer = (TextMessage) consumer2.receiveNoWait();
+ answer = (TextMessage) consumer2.receive(5000);
--- End diff --
@clebertsuconic yes something is async. If you following session.commit() at server, it's async, which means after commit you can't expect the message is already at client side. You have to give it some time to allow messages to be delivered to the client. Using receiveNoWait() is not proper here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #581: ARTEMIS-571 Fix issues in openwire tests...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/581#discussion_r67510743
--- Diff: tests/activemq5-unit-tests/src/test/java/org/apache/activemq/ZeroPrefetchConsumerTest.java ---
@@ -157,9 +157,9 @@ public void testTwoConsumers() throws Exception {
// now lets receive it
MessageConsumer consumer1 = session.createConsumer(queue);
MessageConsumer consumer2 = session.createConsumer(queue);
- TextMessage answer = (TextMessage) consumer1.receiveNoWait();
+ TextMessage answer = (TextMessage) consumer1.receive(5000);
assertEquals("Should have received a message!", answer.getText(), "Msg1");
- answer = (TextMessage) consumer2.receiveNoWait();
+ answer = (TextMessage) consumer2.receive(5000);
--- End diff --
I don\t think this is a valid fix...
I would rather fix the flush on the server.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---