You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by "wgtmac (via GitHub)" <gi...@apache.org> on 2023/06/16 09:11:23 UTC

[GitHub] [parquet-format] wgtmac commented on a diff in pull request #203: PARQUET-2313: Bump actions/setup-java from 1 to 3

wgtmac commented on code in PR #203:
URL: https://github.com/apache/parquet-format/pull/203#discussion_r1231995750


##########
.github/workflows/test.yml:
##########
@@ -26,15 +26,16 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        java: [ '1.8', '11' ]
+        java: [ '8', '11', '17' ]
     name: Build Parquet with JDK ${{ matrix.java }}
 
     steps:
       - uses: actions/checkout@master
       - name: Set up JDK ${{ matrix.java }}
-        uses: actions/setup-java@v1
+        uses: actions/setup-java@v3
         with:
           java-version: ${{ matrix.java }}
+          distribution: temurin

Review Comment:
   @Fokko Why do we need to specify a distribution?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org