You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Olga Natkovich (JIRA)" <ji...@apache.org> on 2009/12/15 23:49:18 UTC
[jira] Created: (PIG-1155) Need to make sure existing loaders work
"as is"
Need to make sure existing loaders work "as is"
-----------------------------------------------
Key: PIG-1155
URL: https://issues.apache.org/jira/browse/PIG-1155
Project: Pig
Issue Type: Bug
Affects Versions: 0.6.0
Reporter: Olga Natkovich
Assignee: Daniel Dai
Fix For: 0.6.0
Need to make sure that existing loaders work "as is" without requiring recompile for new fieldsRequired signature. Currently, they fail.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1155) Need to make sure existing loaders
work "as is"
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791118#action_12791118 ]
Olga Natkovich commented on PIG-1155:
-------------------------------------
+1 on the code change.
> Need to make sure existing loaders work "as is"
> -----------------------------------------------
>
> Key: PIG-1155
> URL: https://issues.apache.org/jira/browse/PIG-1155
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.6.0
> Reporter: Olga Natkovich
> Assignee: Daniel Dai
> Fix For: 0.6.0
>
> Attachments: PIG-1155-1.patch
>
>
> Need to make sure that existing loaders work "as is" without requiring recompile for new fieldsRequired signature. Currently, they fail.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1155) Need to make sure existing loaders work
"as is"
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1155:
----------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Patch committed to both trunk and 0.6 branch.
> Need to make sure existing loaders work "as is"
> -----------------------------------------------
>
> Key: PIG-1155
> URL: https://issues.apache.org/jira/browse/PIG-1155
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.6.0
> Reporter: Olga Natkovich
> Assignee: Daniel Dai
> Fix For: 0.6.0
>
> Attachments: PIG-1155-1.patch
>
>
> Need to make sure that existing loaders work "as is" without requiring recompile for new fieldsRequired signature. Currently, they fail.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1155) Need to make sure existing loaders
work "as is"
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791388#action_12791388 ]
Hadoop QA commented on PIG-1155:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12428115/PIG-1155-1.patch
against trunk revision 890596.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/129/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/129/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/129/console
This message is automatically generated.
> Need to make sure existing loaders work "as is"
> -----------------------------------------------
>
> Key: PIG-1155
> URL: https://issues.apache.org/jira/browse/PIG-1155
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.6.0
> Reporter: Olga Natkovich
> Assignee: Daniel Dai
> Fix For: 0.6.0
>
> Attachments: PIG-1155-1.patch
>
>
> Need to make sure that existing loaders work "as is" without requiring recompile for new fieldsRequired signature. Currently, they fail.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1155) Need to make sure existing loaders work
"as is"
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1155:
----------------------------
Status: Patch Available (was: Open)
> Need to make sure existing loaders work "as is"
> -----------------------------------------------
>
> Key: PIG-1155
> URL: https://issues.apache.org/jira/browse/PIG-1155
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.6.0
> Reporter: Olga Natkovich
> Assignee: Daniel Dai
> Fix For: 0.6.0
>
> Attachments: PIG-1155-1.patch
>
>
> Need to make sure that existing loaders work "as is" without requiring recompile for new fieldsRequired signature. Currently, they fail.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1155) Need to make sure existing loaders work
"as is"
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1155:
----------------------------
Attachment: PIG-1155-1.patch
Attach a patch. Don't have way to generate the obsolete class in the code. So skip unit test and do manual test.
> Need to make sure existing loaders work "as is"
> -----------------------------------------------
>
> Key: PIG-1155
> URL: https://issues.apache.org/jira/browse/PIG-1155
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.6.0
> Reporter: Olga Natkovich
> Assignee: Daniel Dai
> Fix For: 0.6.0
>
> Attachments: PIG-1155-1.patch
>
>
> Need to make sure that existing loaders work "as is" without requiring recompile for new fieldsRequired signature. Currently, they fail.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.