You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "icexelloss (via GitHub)" <gi...@apache.org> on 2023/04/05 15:17:14 UTC

[GitHub] [arrow] icexelloss commented on pull request #34777: MINOR: [C++] Remove std::move when calling ProcessEmit and ProcessExtensionEmit

icexelloss commented on PR #34777:
URL: https://github.com/apache/arrow/pull/34777#issuecomment-1497666792

   > Thanks. I definitely agree with removing `std::move` when calling `ProcessEmit`. I'm not sure about the return statement though (see my reply to your comment).
   
   Got it. I do see in other places where `std::move` is used for return. I guess it is a larger scope discussion whether we want to change that or not. Will revert that part.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org