[GitHub] [skywalking] tmichnik1981 commented on issue #2653: Improve Zipkin<->SkyWalking integration

[GitBox <gi...@apache.org>]

tmichnik1981 commented on issue #2653: Improve Zipkin<->SkyWalking integration
URL: https://github.com/apache/skywalking/issues/2653#issuecomment-492169627
 
 
   I found some inconsistency regarding Zipkin spans. 
   I am testing with a setting `needAnalysis=true`. I see that tracing is not visible.
   It turned out skywalking queries   index **zipkin_span** which is empty.
   
   On the other hand, when needAnalysis=false, `org.apache.skywalking.oap.server.receiver.zipkin.trace.SpanForward#send` is called and spans are being saved to  **zipkin_span**.
   
   Should  **zipkin_span** be populated with spans or we should rather query some other index when browsing tracing?
   
   I see that in `org.apache.skywalking.oap.server.core.query.TraceQueryService` a decision is made which DAO to load. Of course in my case Zipkin storage is on so `org.apache.skywalking.oap.server.storage.plugin.zipkin.elasticsearch.ZipkinTraceQueryEsDAO` is loaded.
   
   ```
      private ITraceQueryDAO getTraceQueryDAO() {
           if (traceQueryDAO == null) {
               this.traceQueryDAO = moduleManager.find(StorageModule.NAME).provider().getService(ITraceQueryDAO.class);
           }
           return traceQueryDAO;
       }
   ```
    
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services