You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/01/08 13:18:10 UTC
[GitHub] [logging-log4cxx] coldtobi opened a new pull request #99: [LOG4CXX-548] Reproducible Doxygen doc generation
coldtobi opened a new pull request #99:
URL: https://github.com/apache/logging-log4cxx/pull/99
The way the doxygen documenation is generated with CMake, it is unfortunatly
not reproducible (as in https://reproducible-builds.org/).
This is a regression as log4cxx has been previously reproducible (at least on
Debian –
https://tests.reproducible-builds.org/debian/rb-pkg/experimental/amd64/log4cxx.html)
The problem is that doxygen's configure has several absolute paths, which it
then bakes into the generated documentation, for example in this snippt, the
bold part dependent on the build path:
<div class="contents">
<div class="textblock"><p><a class="anchor" id="md__build_log4cxx_0_12_1_src_site_markdown_index"></a></p>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4cxx] rm5248 merged pull request #99: [LOG4CXX-548] Reproducible Doxygen doc generation
Posted by GitBox <gi...@apache.org>.
rm5248 merged pull request #99:
URL: https://github.com/apache/logging-log4cxx/pull/99
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4cxx] coldtobi edited a comment on pull request #99: [LOG4CXX-548] Reproducible Doxygen doc generation
Posted by GitBox <gi...@apache.org>.
coldtobi edited a comment on pull request #99:
URL: https://github.com/apache/logging-log4cxx/pull/99#issuecomment-1008185839
> The patch as given requires CMake 3.20+, but doesn't update the minimum required version. I'd like to not have to bump the CMake version if possible.
Ack.
> I changed the `cmake_path` directive to `file(RELATIVE_PATH LOG4CXX_REL_BIN_TO_SRC_DIR "${LOG4CXX_SOURCE_DIR}" "${CMAKE_CURRENT_BINARY_DIR}")` on my side which seems to work fine, would you be able to validate that?
LGTM, it builds reproducible as well on my machine. I'll update my PR accordingly.
> I don't see where the particular example that you showed is coming in from, that only seems to be a problem with the MapFilter page.
It seems everything in site/markdown triggering the differences... Here's a (local created) complete diff: https://pastebin.com/6BLaEa0K. (So it is quite possible that only the INPUT configuration of Doxyfile.in would need to be relative, but I believe making the other relative won't hurt.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4cxx] coldtobi commented on pull request #99: [LOG4CXX-548] Reproducible Doxygen doc generation
Posted by GitBox <gi...@apache.org>.
coldtobi commented on pull request #99:
URL: https://github.com/apache/logging-log4cxx/pull/99#issuecomment-1008185839
> The patch as given requires CMake 3.20+, but doesn't update the minimum required version. I'd like to not have to bump the CMake version if possible.
Ack.
> I changed the `cmake_path` directive to `file(RELATIVE_PATH LOG4CXX_REL_BIN_TO_SRC_DIR "${LOG4CXX_SOURCE_DIR}" "${CMAKE_CURRENT_BINARY_DIR}")` on my side which seems to work fine, would you be able to validate that?
LGTM, it build reproducible as well on my machine. I'll update my PR accordingly.
> I don't see where the particular example that you showed is coming in from, that only seems to be a problem with the MapFilter page.
It seems everything in site/markdown triggering the differences... Here's a (local created) complete diff: https://pastebin.com/6BLaEa0K. (So it is quite possible that only the INPUT configuration of Doxyfile.in would need to be relative, but I believe making the other relative won't hurt.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4cxx] rm5248 commented on pull request #99: [LOG4CXX-548] Reproducible Doxygen doc generation
Posted by GitBox <gi...@apache.org>.
rm5248 commented on pull request #99:
URL: https://github.com/apache/logging-log4cxx/pull/99#issuecomment-1008162731
The patch as given requires CMake 3.20+, but doesn't update the minimum required version. I'd like to not have to bump the CMake version if possible.
I changed the `cmake_path` directive to `file(RELATIVE_PATH LOG4CXX_REL_BIN_TO_SRC_DIR "${LOG4CXX_SOURCE_DIR}" "${CMAKE_CURRENT_BINARY_DIR}")` on my side which seems to work fine, would you be able to validate that? I don't see where the particular example that you showed is coming in from, that only seems to be a problem with the MapFilter page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org