You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "kgyrtkirk (via GitHub)" <gi...@apache.org> on 2024/05/28 14:32:20 UTC
[PR] Make a full copy of the parser and apply our modifications to it (druid)
kgyrtkirk opened a new pull request, #16503:
URL: https://github.com/apache/druid/pull/16503
To enable easier access to enhance the parser - instead of copying parts of it this PR proposes to keep a full copy with our modifications in the repo. This makes:
* a more easier to understand build
* the build will unpack the "base" version of the parser to `sql/target/calcite-base-parser` ; so its relatively easy to see what have changed
* more freedom on what could be modified later
* upgrade is "different":
* this PR contains a script which could help during upgrades (dev/updgrade-calcite-parser)
* it restores the parse into the original state and apply our modifications and the updated ones and then merge it - this process should more or less finish successfully
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Make a full copy of the parser and apply our modifications to it (druid)
Posted by "kgyrtkirk (via GitHub)" <gi...@apache.org>.
kgyrtkirk commented on PR #16503:
URL: https://github.com/apache/druid/pull/16503#issuecomment-2154227466
@rohangarg @gianm @clintropolis: I wonder if you could take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Make a full copy of the parser and apply our modifications to it (druid)
Posted by "kgyrtkirk (via GitHub)" <gi...@apache.org>.
kgyrtkirk closed pull request #16503: Make a full copy of the parser and apply our modifications to it
URL: https://github.com/apache/druid/pull/16503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org