You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "HattoriHenzo (via GitHub)" <gi...@apache.org> on 2023/03/10 00:58:04 UTC
[GitHub] [incubator-eventmesh] HattoriHenzo opened a new pull request, #3387: [ISSUE #3386] Refactor HistoryMessageClearTask
HattoriHenzo opened a new pull request, #3387:
URL: https://github.com/apache/incubator-eventmesh/pull/3387
Fixes https://github.com/apache/incubator-eventmesh/issues/3386
### Motivation
Delegate the execution of the history clear login in another runnable class
### Modifications
`HistoryMessageClearTask` has been splitted into two classes: `HistoryMessageClear `to implement the logic and `HistoryMessageClearTask `to run in another thread.
It will help simplify the test of `HistoryMessageClearTask`
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 merged pull request #3387: [ISSUE #3386] Refactor HistoryMessageClearTask
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3387:
URL: https://github.com/apache/incubator-eventmesh/pull/3387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #3387: [ISSUE #3386] Refactor HistoryMessageClearTask
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3387:
URL: https://github.com/apache/incubator-eventmesh/pull/3387#issuecomment-1463081850
## [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/3387?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3387](https://codecov.io/gh/apache/incubator-eventmesh/pull/3387?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (45f9f68) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/ed162b70ddc6a8da7eea08554f56c1a6e780ce08?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ed162b7) will **increase** coverage by `0.00%`.
> The diff coverage is `61.11%`.
> :exclamation: Current head 45f9f68 differs from pull request most recent head d281998. Consider uploading reports for the commit d281998 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3387 +/- ##
=========================================
Coverage 13.89% 13.90%
- Complexity 1435 1438 +3
=========================================
Files 635 636 +1
Lines 31375 31373 -2
Branches 3025 3010 -15
=========================================
+ Hits 4360 4362 +2
+ Misses 26636 26634 -2
+ Partials 379 377 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/3387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...or/standalone/broker/task/HistoryMessageClear.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL3Rhc2svSGlzdG9yeU1lc3NhZ2VDbGVhci5qYXZh) | `46.15% <46.15%> (ø)` | |
| [.../connector/standalone/broker/StandaloneBroker.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL1N0YW5kYWxvbmVCcm9rZXIuamF2YQ==) | `56.52% <100.00%> (+0.96%)` | :arrow_up: |
| [...tandalone/broker/task/HistoryMessageClearTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL3Rhc2svSGlzdG9yeU1lc3NhZ2VDbGVhclRhc2suamF2YQ==) | `50.00% <100.00%> (+20.58%)` | :arrow_up: |
... and [6 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-eventmesh/pull/3387/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org