You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prasadwagle <gi...@git.apache.org> on 2016/08/03 04:03:41 UTC
[GitHub] zeppelin pull request #1270: [ZEPPELIN-1273] Use Math.abs to determine if cu...
GitHub user prasadwagle opened a pull request:
https://github.com/apache/zeppelin/pull/1270
[ZEPPELIN-1273] Use Math.abs to determine if custom formatter should be called for y axis values
### What is this PR for?
Use Math.abs to determine if custom formatter should be called for y axis values.
### What type of PR is it?
Bug Fix
### Todos
* [ ] - Task
### What is the Jira issue?
[ZEPPELIN-1273] https://issues.apache.org/jira/browse/ZEPPELIN-1273
### How should this be tested?
Create simple table with two columns - date in one and large negative numbers like -10000000 in other. Display line chart and see that the y axis values are formatted like -10M.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
No
* Is there breaking changes for older versions?
No
* Does this needs documentation?
No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prasadwagle/incubator-zeppelin ZEPPELIN-1273
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1270.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1270
----
commit 06e12f88e3d39f6b090ad8c9fc346491f9e79908
Author: Prasad Wagle <pw...@twitter.com>
Date: 2016-08-03T03:57:13Z
Use Math.abs to determine if custom formatter should be called for y axis values
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1270: [ZEPPELIN-1273] Use Math.abs to determine if custom fo...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1270
Looks great to me, thank you @praagarw
Merging to only to master, if there is no further discussion
Or do you think we should also apply this to upcoming 0.6.1 as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1270: [ZEPPELIN-1273] Use Math.abs to determine if cu...
Posted by prasadwagle <gi...@git.apache.org>.
Github user prasadwagle closed the pull request at:
https://github.com/apache/zeppelin/pull/1270
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1270: [ZEPPELIN-1273] Use Math.abs to determine if cu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1270
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1270: [ZEPPELIN-1273] Use Math.abs to determine if cu...
Posted by prasadwagle <gi...@git.apache.org>.
GitHub user prasadwagle reopened a pull request:
https://github.com/apache/zeppelin/pull/1270
[ZEPPELIN-1273] Use Math.abs to determine if custom formatter should be called for y axis values
### What is this PR for?
Use Math.abs to determine if custom formatter should be called for y axis values.
### What type of PR is it?
Bug Fix
### Todos
* [ ] - Task
### What is the Jira issue?
[ZEPPELIN-1273] https://issues.apache.org/jira/browse/ZEPPELIN-1273
### How should this be tested?
Create simple table with two columns - date in one and large negative numbers like -10000000 in other. Display line chart and see that the y axis values are formatted like -10M.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
No
* Is there breaking changes for older versions?
No
* Does this needs documentation?
No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prasadwagle/incubator-zeppelin ZEPPELIN-1273
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1270.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1270
----
commit 06e12f88e3d39f6b090ad8c9fc346491f9e79908
Author: Prasad Wagle <pw...@twitter.com>
Date: 2016-08-03T03:57:13Z
Use Math.abs to determine if custom formatter should be called for y axis values
commit 2c62f5669f7a0f45e48ea1a94a8bb39ab7ea00ce
Author: Prasad Wagle <pw...@twitter.com>
Date: 2016-08-03T16:53:40Z
Merge branch 'master' into ZEPPELIN-1273
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1270: [ZEPPELIN-1273] Use Math.abs to determine if custom fo...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1270
Let's merge! :Shipit:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1270: [ZEPPELIN-1273] Use Math.abs to determine if custom fo...
Posted by prasadwagle <gi...@git.apache.org>.
Github user prasadwagle commented on the issue:
https://github.com/apache/zeppelin/pull/1270
> Or do you think we should also apply this to upcoming 0.6.1 as well?
I can do that. What branch should I use for 0.6.1?
I merged with latest master this morning. Two checks in the build failed. Any ideas how to fix? I am going to restart the build in case they are due to flaky tests.
```
https://travis-ci.org/apache/zeppelin/jobs/149535074
Results :
Failed tests:
ZeppelinSparkClusterTest.zRunTest:204 expected:<FINISHED> but was:<ERROR>
https://travis-ci.org/apache/zeppelin/jobs/149535075
Tests in error:
SparkInterpreterTest.setUp:93 » NullPointer
SparkInterpreterTest.shareSingleSparkContext:245 » NullPointer
SparkInterpreterTest.testBasicIntp:136 » NullPointer
SparkInterpreterTest.testCreateDataFrame:182 » NullPointer
SparkInterpreterTest.testDisableImplicitImport:280 » NullPointer
SparkInterpreterTest.testEnableImplicitImport:264 » NullPointer
SparkInterpreterTest.testEndWithComment:171 » NullPointer
SparkInterpreterTest.testListener:176 » NullPointer
SparkInterpreterTest.testNextLineComments:160 » NullPointer
SparkInterpreterTest.testNextLineCompanionObject:166 » NullPointer
SparkInterpreterTest.testNextLineInvocation:155 » NullPointer
SparkInterpreterTest.testReferencingUndefinedVal:220 » NullPointer
SparkInterpreterTest.testSparkSql:200 » NullPointer
SparkInterpreterTest.testZShow:193 » NullPointer
SparkSqlInterpreterTest.setUp:61 » NullPointer
SparkSqlInterpreterTest.setUp:61 » NullPointer
SparkSqlInterpreterTest.setUp:61 » NullPointer
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1270: [ZEPPELIN-1273] Use Math.abs to determine if custom fo...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1270
@prasadwagle Thanks for the fix!
LGTM. I don't think it's blocker for 0.6.1 release, but it will be nice if we can include it in 0.6.1 release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1270: [ZEPPELIN-1273] Use Math.abs to determine if custom fo...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1270
merge into master and branch-0.6 if there're no more discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---