You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Michael Semb Wever (Jira)" <ji...@apache.org> on 2020/01/01 12:37:00 UTC
[jira] [Commented] (CASSANDRA-14306) Single config variable to
specify logs path
[ https://issues.apache.org/jira/browse/CASSANDRA-14306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17006389#comment-17006389 ]
Michael Semb Wever commented on CASSANDRA-14306:
------------------------------------------------
||branch||circleci||asf jenkins testall||asf jenkins dtests||
|[cassandra-3.0_14306|https://github.com/apache/cassandra/compare/cassandra-3.0...thelastpickle:mck/cassandra-3.0_14306]|[circleci|https://circleci.com/gh/thelastpickle/workflows/cassandra/tree/mck%2Fcassandra-3.0_14306]|[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/39/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/39/]|[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/712/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/712]|
|[cassandra-3.11_14306|https://github.com/apache/cassandra/compare/cassandra-3.11...thelastpickle:mck/cassandra-3.11_14306]|[circleci|https://circleci.com/gh/thelastpickle/workflows/cassandra/tree/mck%2Fcassandra-3.11_14306]|[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/40/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/40/]|[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/713/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/713]|
|[trunk_14306|https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/trunk_14306]|[circleci|https://circleci.com/gh/thelastpickle/workflows/cassandra/tree/mck%2Ftrunk_14306]|[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/41/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/41/]|[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/714/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/714]|
> Single config variable to specify logs path
> -------------------------------------------
>
> Key: CASSANDRA-14306
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14306
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config
> Reporter: Angelo Polo
> Priority: Low
> Attachments: unified_logs_dir.patch, unified_logs_dir_v2_3.11.patch, unified_logs_dir_v2_trunk.patch
>
>
> Motivation: All configuration should take place in bin/cassandra.in.sh (for non-Windows) and the various conf/ files. In particular, bin/cassandra should not need to be modified upon installation. In many installs, $CASSANDRA_HOME is not a writable location, the yaml setting 'data_file_directories' is being set to a non-default location, etc. It would be good to have a single variable in an explicit conf file to specify where logs should be written.
> For non-Windows installs, there are currently two places where the log directory is set: in conf/cassandra-env.sh and in bin/cassandra. The defaults for these are both $CASSANDRA_HOME/logs. These can be unified to a single variable CASSANDRA_LOGS that is set in conf/cassandra-env.sh, with the intention that it would be modified once there (if not set in the environment) by a user running a custom installation. Then include a check in bin/cassandra that CASSANDRA_LOGS is set in case conf/cassandra-env.sh doesn't get sourced on startup, and provide a default value if not. For the scenario that a user would prefer different paths for the logback logs and the GC logs, they can still go into bin/cassandra to set the second path, just as they would do currently. See "unified_logs_dir.patch" for a proposed patch.
> No change seems necessary for the Windows scripts. The two uses of $CASSANDRA_HOME/logs are in the same script conf/cassandra-env.ps1 within scrolling distance of each other (lines 278-301). They haven't been combined I suppose because of the different path separators in the two usages.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org