You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/19 19:08:32 UTC

[GitHub] [superset] AkashN7 commented on a diff in pull request #19837: feat(charts): allow query mutator to update queries after splitting original sql

AkashN7 commented on code in PR #19837:
URL: https://github.com/apache/superset/pull/19837#discussion_r877435243


##########
superset/connectors/sqla/models.py:
##########
@@ -916,7 +916,8 @@ def mutate_query_from_config(self, sql: str) -> str:
 
         Typically adds comments to the query with context"""
         sql_query_mutator = config["SQL_QUERY_MUTATOR"]
-        if sql_query_mutator:
+        mutate_after_split = config["MUTATE_AFTER_SPLIT"]

Review Comment:
   config.py has been updated with a default value and comment on usage



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org