[GitHub] kpm1985 commented on issue #951: FLUO-950 Make VisibilityCache customizable

[GitBox <gi...@apache.org>]

kpm1985 commented on issue #951: FLUO-950 Make VisibilityCache customizable
URL: https://github.com/apache/fluo/pull/951#issuecomment-338538784
 
 
   @keith-turner
   I've pushed some changes. Build fails but I looked it seems unrelated
   (timeout stuff again).
   
   On Oct 22, 2017 6:58 PM, "Keith Turner" <no...@github.com> wrote:
   
   > *@keith-turner* commented on this pull request.
   > ------------------------------
   >
   > In modules/core/src/main/java/org/apache/fluo/core/impl/
   > VisibilityCache.java
   > <https://github.com/apache/fluo/pull/951#discussion_r146154313>:
   >
   > > @@ -48,9 +48,9 @@ public int weigh(Bytes key, ColumnVisibility vis) {
   >
   >    VisibilityCache() {
   >
   > You can modify this constructor to take a FluoConfiguration. The viscache
   > constructor is only called in SharedResources which can be changed to do visCache
   > = new VisibilityCache(env.getConfiguration())
   >
   > ?
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/fluo/pull/951#pullrequestreview-71055487>, or mute
   > the thread
   > <https://github.com/notifications/unsubscribe-auth/Acg-LNe4gR1UYxauf0dY_W3MKrSLq-_Dks5su_K_gaJpZM4QBwap>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services