[jira] [Commented] (HBASE-23814) Add null checks and logging to misc set of tests

["Hudson (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-23814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185326#comment-17185326 ] 

Hudson commented on HBASE-23814:
--------------------------------

Results for branch branch-2.2
	[build #47 on builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/47/]: (x) *{color:red}-1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/47//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/47//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/47//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Add null checks and logging to misc set of tests
> ------------------------------------------------
>
>                 Key: HBASE-23814
>                 URL: https://issues.apache.org/jira/browse/HBASE-23814
>             Project: HBase
>          Issue Type: Test
>            Reporter: Michael Stack
>            Assignee: Michael Stack
>            Priority: Trivial
>             Fix For: 3.0.0-alpha-1, 2.3.0, 2.2.6
>
>
> I've been studying unit tests of late. A few are failing but then the output is missing a detail or shutdown complains of NPE because startup didn't succeed.
> Here are super minor items I've been carrying around that I'd like to land. They do  not change the function of tests (there is an attempt at a fix of TestLogsCleaner).
> * TestFullLogReconstruction log the server we've chosen to expire and then note where we starting counting rows
> * TestAsyncTableScanException use a define for row counts; count 100 instead of 1000 and see if helps
> * TestRawAsyncTableLimitedScanWithFilter check connection was made before closing it in tearDown
> * TestLogsCleaner use single mod time. Make it for sure less than now in case test runs all in the same millisecond (would cause test fail)
> * TestReplicationBase test table is non-null before closing in tearDown



--
This message was sent by Atlassian Jira
(v8.3.4#803005)