You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@singa.apache.org by GitBox <gi...@apache.org> on 2019/08/07 14:51:06 UTC

[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #495: SINGA-475 add SoftSign operator

chrishkchris commented on a change in pull request #495: SINGA-475 add SoftSign operator
URL: https://github.com/apache/incubator-singa/pull/495#discussion_r311597785
 
 

 ##########
 File path: test/python/test_operation.py
 ##########
 @@ -610,6 +610,46 @@ def test_Atanh_gpu(self):
         np.testing.assert_array_almost_equal(tensor.to_numpy(result), XT, decimal=5)
         self.check_shape(dx.shape(), (3, 2))
 
+    def test_SoftSign_cpu(self):
+        # y = x / (1 + np.abs(x))
 
 Review comment:
   Could you delete the line 614 since this is the same as line 616? Thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services