You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/11/19 08:02:31 UTC
[GitHub] [incubator-mxnet] samskalicky opened a new pull request #19565: [v1.x] Save/Load Gluon Blocks & HybridBlocks
samskalicky opened a new pull request #19565:
URL: https://github.com/apache/incubator-mxnet/pull/19565
## Description ##
v1.x branch version of PoC for saving & loading Gluon Blocks & HybridBlocks from #19535
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #19565: [v1.x] Save/Load Gluon Blocks & HybridBlocks
Posted by GitBox <gi...@apache.org>.
samskalicky commented on a change in pull request #19565:
URL: https://github.com/apache/incubator-mxnet/pull/19565#discussion_r541475648
##########
File path: python/mxnet/symbol/symbol.py
##########
@@ -3035,9 +3035,9 @@ def load(fname):
fname : str
The name of the file, examples:
- - `s3://my-bucket/path/my-s3-symbol`
- - `hdfs://my-bucket/path/my-hdfs-symbol`
- - `/path-to/my-local-symbol`
+ - `s3://my-bucket/path/my-s3-symbol`
+ - `hdfs://my-bucket/path/my-hdfs-symbol`
+ - `/path-to/my-local-symbol`
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky commented on pull request #19565: [v1.x] Save/Load Gluon Blocks & HybridBlocks
Posted by GitBox <gi...@apache.org>.
samskalicky commented on pull request #19565:
URL: https://github.com/apache/incubator-mxnet/pull/19565#issuecomment-744743921
> Must not change `load_json` -> `fromjson` in the 1.x branch due to API compatibility
backed out the change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #19565: [v1.x] Save/Load Gluon Blocks & HybridBlocks
Posted by GitBox <gi...@apache.org>.
samskalicky commented on a change in pull request #19565:
URL: https://github.com/apache/incubator-mxnet/pull/19565#discussion_r528051826
##########
File path: python/mxnet/contrib/quantization.py
##########
@@ -376,7 +375,7 @@ def _load_sym(sym, logger=None):
symbol_file_path = os.path.join(cur_path, sym)
if logger:
logger.info('Loading symbol from file %s' % symbol_file_path)
- return sym_load(symbol_file_path)
+ return Symbol.load(symbol_file_path)
Review comment:
this change isnt needed, should revert all changes in this file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #19565: [v1.x] Save/Load Gluon Blocks & HybridBlocks
Posted by GitBox <gi...@apache.org>.
samskalicky commented on a change in pull request #19565:
URL: https://github.com/apache/incubator-mxnet/pull/19565#discussion_r541475619
##########
File path: python/mxnet/contrib/quantization.py
##########
@@ -376,7 +375,7 @@ def _load_sym(sym, logger=None):
symbol_file_path = os.path.join(cur_path, sym)
if logger:
logger.info('Loading symbol from file %s' % symbol_file_path)
- return sym_load(symbol_file_path)
+ return Symbol.load(symbol_file_path)
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19565: [v1.x] Save/Load Gluon Blocks & HybridBlocks
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19565:
URL: https://github.com/apache/incubator-mxnet/pull/19565#issuecomment-730199533
Hey @samskalicky , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [edge, sanity, centos-cpu, unix-gpu, miscellaneous, clang, website, centos-gpu, windows-gpu, windows-cpu, unix-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky merged pull request #19565: [v1.x] Save/Load Gluon Blocks & HybridBlocks
Posted by GitBox <gi...@apache.org>.
samskalicky merged pull request #19565:
URL: https://github.com/apache/incubator-mxnet/pull/19565
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #19565: [v1.x] Save/Load Gluon Blocks & HybridBlocks
Posted by GitBox <gi...@apache.org>.
samskalicky commented on a change in pull request #19565:
URL: https://github.com/apache/incubator-mxnet/pull/19565#discussion_r528051761
##########
File path: python/mxnet/symbol/symbol.py
##########
@@ -3035,9 +3035,9 @@ def load(fname):
fname : str
The name of the file, examples:
- - `s3://my-bucket/path/my-s3-symbol`
- - `hdfs://my-bucket/path/my-hdfs-symbol`
- - `/path-to/my-local-symbol`
+ - `s3://my-bucket/path/my-s3-symbol`
+ - `hdfs://my-bucket/path/my-hdfs-symbol`
+ - `/path-to/my-local-symbol`
Review comment:
should revert this so its indented again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org