You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/07/09 13:40:14 UTC
[GitHub] [incubator-iotdb] LeiRui opened a new pull request #228: remove
useless fetchSize in some places
LeiRui opened a new pull request #228: remove useless fetchSize in some places
URL: https://github.com/apache/incubator-iotdb/pull/228
`fetchSize` is a parameter used to control the size of the query dataset that the client fetches from the server at a time. The default value of `fetchSize` is 10000 as set in `Config`.
From the client JDBC side, `fetchSize` is an attribute of `IoTDBStatement` and it is passed to the server as shown by the following two lines when JDBC implements `nextWithoutConstraints` to get the query result:
> TSFetchResultsReq req = new TSFetchResultsReq(sql, fetchSize, queryId);
> TSFetchResultsResp resp = client.fetchResults(req);
From the server side, `fetchSize` is used in `TSServiceImpl.fetchResults` by the following two lines:
1. > queryDataSet = createNewDataSet(statement, fetchSize, req);
2. > QueryDataSetUtils.convertQueryDataSetByFetchSize(queryDataSet, fetchSize)
However, `fetchSize` is actually useless in the first line. Thus, this pr is aimed at removing this kind of useless `fetchSize`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services