You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/10 09:18:10 UTC
[GitHub] [apisix-go-plugin-runner] Belyenochi opened a new pull request #63: feature: try to introduce context to plugin runner
Belyenochi opened a new pull request #63:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/63
There are two things I don't understand
First, I don't know when to add Context to Request to capture cancellation logic (HttpClient.Do implementation of Http package relies on infinite loop to capture ctx.Done), does this mean that plugin writers need to get context and do some processing by themselves
Second, if the TimeOut time is set globally, what is the meaning of the context in the Request structure of the Plugin?
for zh
有两个不理解的地方还望指点！
第一，我不了解如果在Request里加上Context何时去捕获取消逻辑（Http包的HttpClient.Do实现依赖死循环去捕获ctx.Done），这是否意味着plugin编写者需要获取context自己做一些处理
第二，如果TimeOut时间全局设置了那么Plugin的Request结构包含context的意义是什么呢？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] Belyenochi removed a comment on pull request #63: feature: try to introduce context to plugin runner
Posted by GitBox <gi...@apache.org>.
Belyenochi removed a comment on pull request #63:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/63#issuecomment-1038708045
> Need to set the `ctx` to nil in
>
> https://github.com/apache/apisix-go-plugin-runner/blob/1a00a4b14f930c4588ede207c18c341336a760fd/internal/http/request.go#L160
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] Belyenochi commented on pull request #63: feature: try to introduce context to plugin runner
Posted by GitBox <gi...@apache.org>.
Belyenochi commented on pull request #63:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/63#issuecomment-1038592328
> Don't forget to add a test to cover it.
Yes, I added a simple Context unit test, please feel free to drop me a message if you have good optimization suggestions, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] Belyenochi edited a comment on pull request #63: feature: try to introduce context to plugin runner
Posted by GitBox <gi...@apache.org>.
Belyenochi edited a comment on pull request #63:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/63#issuecomment-1041055979
> Need to set the `ctx` to nil in
>
> https://github.com/apache/apisix-go-plugin-runner/blob/1a00a4b14f930c4588ede207c18c341336a760fd/internal/http/request.go#L160
pls help to approve again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] spacewander commented on a change in pull request #63: feature: try to introduce context to plugin runner
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #63:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/63#discussion_r805534037
##########
File path: internal/plugin/plugin.go
##########
@@ -20,13 +20,12 @@ package plugin
import (
"errors"
"fmt"
+ hrc "github.com/api7/ext-plugin-proto/go/A6/HTTPReqCall"
Review comment:
Need a configuration to separate the imports
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] Belyenochi commented on pull request #63: feature: try to introduce context to plugin runner
Posted by GitBox <gi...@apache.org>.
Belyenochi commented on pull request #63:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/63#issuecomment-1038708045
> Need to set the `ctx` to nil in
>
> https://github.com/apache/apisix-go-plugin-runner/blob/1a00a4b14f930c4588ede207c18c341336a760fd/internal/http/request.go#L160
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] Belyenochi commented on pull request #63: feature: try to introduce context to plugin runner
Posted by GitBox <gi...@apache.org>.
Belyenochi commented on pull request #63:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/63#issuecomment-1039065243
> Need to set the `ctx` to nil in
>
> https://github.com/apache/apisix-go-plugin-runner/blob/1a00a4b14f930c4588ede207c18c341336a760fd/internal/http/request.go#L160
Thanks for the code review, done fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] codecov-commenter edited a comment on pull request #63: feature: try to introduce context to plugin runner
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #63:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/63#issuecomment-1035914590
# [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#63](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fed69d0) into [master](https://codecov.io/gh/apache/apisix-go-plugin-runner/commit/6bb1c4bd98ec374638af7ed02931e0efb2604044?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6bb1c4b) will **increase** coverage by `3.09%`.
> The diff coverage is `88.88%`.
[](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
+ Coverage 77.74% 80.84% +3.09%
==========================================
Files 11 11
Lines 701 710 +9
==========================================
+ Hits 545 574 +29
+ Misses 119 100 -19
+ Partials 37 36 -1
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [internal/http/request.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvaHR0cC9yZXF1ZXN0Lmdv) | `94.28% <88.88%> (-0.25%)` | :arrow_down: |
| [internal/http/response.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvaHR0cC9yZXNwb25zZS5nbw==) | `100.00% <0.00%> (ø)` | |
| [internal/server/server.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvc2VydmVyL3NlcnZlci5nbw==) | `67.47% <0.00%> (+17.07%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6bb1c4b...fed69d0](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] codecov-commenter edited a comment on pull request #63: feature: try to introduce context to plugin runner
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #63:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/63#issuecomment-1035914590
# [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#63](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (251249c) into [master](https://codecov.io/gh/apache/apisix-go-plugin-runner/commit/6bb1c4bd98ec374638af7ed02931e0efb2604044?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6bb1c4b) will **increase** coverage by `1.26%`.
> The diff coverage is `88.88%`.
[](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
+ Coverage 77.74% 79.01% +1.26%
==========================================
Files 11 11
Lines 701 710 +9
==========================================
+ Hits 545 561 +16
+ Misses 119 112 -7
Partials 37 37
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [internal/http/request.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvaHR0cC9yZXF1ZXN0Lmdv) | `94.28% <88.88%> (-0.25%)` | :arrow_down: |
| [internal/http/response.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvaHR0cC9yZXNwb25zZS5nbw==) | `100.00% <0.00%> (ø)` | |
| [internal/server/server.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvc2VydmVyL3NlcnZlci5nbw==) | `56.91% <0.00%> (+6.50%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6bb1c4b...251249c](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] Belyenochi edited a comment on pull request #63: feature: try to introduce context to plugin runner
Posted by GitBox <gi...@apache.org>.
Belyenochi edited a comment on pull request #63:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/63#issuecomment-1042519146
hi @spacewander, pls help to approve running workflows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] Belyenochi edited a comment on pull request #63: feature: try to introduce context to plugin runner
Posted by GitBox <gi...@apache.org>.
Belyenochi edited a comment on pull request #63:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/63#issuecomment-1042519146
hi @spacewander, pls help to approve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] Belyenochi commented on pull request #63: feature: try to introduce context to plugin runner
Posted by GitBox <gi...@apache.org>.
Belyenochi commented on pull request #63:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/63#issuecomment-1042519146
hi @spacewander please help to approve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] spacewander commented on a change in pull request #63: feature: try to introduce context to plugin runner
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #63:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/63#discussion_r804383251
##########
File path: internal/plugin/plugin.go
##########
@@ -134,7 +136,9 @@ func reportAction(id uint32, req *inHTTP.Request, resp *inHTTP.Response) *flatbu
}
func HTTPReqCall(buf []byte, conn net.Conn) (*flatbuffers.Builder, error) {
- req := inHTTP.CreateRequest(buf)
+ ctx, cancel := context.WithTimeout(context.Background(), 56*time.Second)
+ defer cancel()
+ req := inHTTP.CreateRequest(buf).WithContext(ctx)
Review comment:
Better to set the ctx inside `CreateRequest` instead of providing it as a method.
As we will reuse the Request, such a method will make reusing impossible.
##########
File path: internal/plugin/plugin.go
##########
@@ -134,7 +136,9 @@ func reportAction(id uint32, req *inHTTP.Request, resp *inHTTP.Response) *flatbu
}
func HTTPReqCall(buf []byte, conn net.Conn) (*flatbuffers.Builder, error) {
- req := inHTTP.CreateRequest(buf)
+ ctx, cancel := context.WithTimeout(context.Background(), 56*time.Second)
Review comment:
Better to add a comment to explain why 56 is chosen.
##########
File path: internal/http/request.go
##########
@@ -18,18 +18,18 @@
package http
import (
+ "context"
"encoding/binary"
+ "github.com/api7/ext-plugin-proto/go/A6"
Review comment:
Let's configure your environment to make sure 3 party imports are sorted separated.
##########
File path: internal/http/request.go
##########
@@ -52,6 +52,26 @@ type Request struct {
rawArgs url.Values
vars map[string][]byte
+
+ ctx context.Context
+}
+
+func (r *Request) Context() context.Context {
+ if r.ctx != nil {
+ return r.ctx
Review comment:
Don't forget to reset the ctx before reusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] Belyenochi edited a comment on pull request #63: feature: try to introduce context to plugin runner
Posted by GitBox <gi...@apache.org>.
Belyenochi edited a comment on pull request #63:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/63#issuecomment-1038592328
> Don't forget to add a test to cover it.
Yes, I added a simple Context unit test, please feel free to drop me a message if you have good optimization suggestions, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] Belyenochi edited a comment on pull request #63: feature: try to introduce context to plugin runner
Posted by GitBox <gi...@apache.org>.
Belyenochi edited a comment on pull request #63:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/63#issuecomment-1041055979
> Need to set the `ctx` to nil in
>
> https://github.com/apache/apisix-go-plugin-runner/blob/1a00a4b14f930c4588ede207c18c341336a760fd/internal/http/request.go#L160
sorry but pls help to approve again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] spacewander commented on pull request #63: feature: try to introduce context to plugin runner
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #63:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/63#issuecomment-1043846335
Merged. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] spacewander merged pull request #63: feature: try to introduce context to plugin runner
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #63:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/63
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] Belyenochi commented on pull request #63: feature: try to introduce context to plugin runner
Posted by GitBox <gi...@apache.org>.
Belyenochi commented on pull request #63:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/63#issuecomment-1041040513
> approve running workflows.
pls approve running workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] Belyenochi commented on pull request #63: feature: try to introduce context to plugin runner
Posted by GitBox <gi...@apache.org>.
Belyenochi commented on pull request #63:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/63#issuecomment-1041055979
> Need to set the `ctx` to nil in
>
> https://github.com/apache/apisix-go-plugin-runner/blob/1a00a4b14f930c4588ede207c18c341336a760fd/internal/http/request.go#L160
sorry but please help to approve again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] codecov-commenter commented on pull request #63: feature: try to introduce context to plugin runner
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #63:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/63#issuecomment-1035914590
# [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#63](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (83acf28) into [master](https://codecov.io/gh/apache/apisix-go-plugin-runner/commit/6bb1c4bd98ec374638af7ed02931e0efb2604044?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6bb1c4b) will **increase** coverage by `1.80%`.
> The diff coverage is `21.42%`.
[](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
+ Coverage 77.74% 79.55% +1.80%
==========================================
Files 11 11
Lines 701 714 +13
==========================================
+ Hits 545 568 +23
+ Misses 119 110 -9
+ Partials 37 36 -1
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [internal/http/request.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvaHR0cC9yZXF1ZXN0Lmdv) | `89.62% <0.00%> (-4.91%)` | :arrow_down: |
| [internal/plugin/plugin.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvcGx1Z2luL3BsdWdpbi5nbw==) | `79.36% <100.00%> (+0.67%)` | :arrow_up: |
| [internal/server/server.go](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvc2VydmVyL3NlcnZlci5nbw==) | `67.47% <0.00%> (+17.07%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6bb1c4b...83acf28](https://codecov.io/gh/apache/apisix-go-plugin-runner/pull/63?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org