You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "rishabhdaim (via GitHub)" <gi...@apache.org> on 2024/02/05 12:50:16 UTC
[PR] OAK-10633 : make embedded verification configurable in detailedGC [jackrabbit-oak]
rishabhdaim opened a new pull request, #1294:
URL: https://github.com/apache/jackrabbit-oak/pull/1294
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10633 : make embedded verification configurable in detailedGC [jackrabbit-oak]
Posted by "rishabhdaim (via GitHub)" <gi...@apache.org>.
rishabhdaim commented on code in PR #1294:
URL: https://github.com/apache/jackrabbit-oak/pull/1294#discussion_r1479455964
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/rdb/RDBDocumentNodeStoreBuilder.java:
##########
@@ -138,4 +138,26 @@ public RDBDocumentNodeStoreBuilder setDocStoreDetailedGCFeature(@Nullable Featur
public Feature getDocStoreDetailedGCFeature() {
return null;
}
+
+ @Override
+ public boolean isEmbeddedVerificationEnabled() {
+ return false;
Review Comment:
Please find the reason here : https://issues.apache.org/jira/browse/OAK-10199?focusedCommentId=17751662&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17751662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10633 : make embedded verification configurable in detailedGC [jackrabbit-oak]
Posted by "stefan-egli (via GitHub)" <gi...@apache.org>.
stefan-egli commented on code in PR #1294:
URL: https://github.com/apache/jackrabbit-oak/pull/1294#discussion_r1478443657
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreService.java:
##########
@@ -185,7 +186,12 @@ public class DocumentNodeStoreService {
/**
* Feature toggle name to enable detailed GC for Mongo Document Store
*/
- private static final String FT_NAME_DEATILED_GC = "FT_DETAILED_GC_OAK-10199";
+ private static final String FT_NAME_DETAILED_GC = "FT_DETAILED_GC_OAK-10199";
+
+ /**
+ * Feature toggle name to enable embedded verification for detailed GC mode for Mongo Document Store
+ */
+ private static final String FT_NAME_EMBEDDED_VERIFICATION = "FT_EMBEDDED_VERIFICATION_OAK-10633";
Review Comment:
Starting to think that we might have to revisit our use of feature toggle for DocumentNodeStore (besides the fact that we still have legacy system properties) : it looks like we more and more opt to not only introduce new config options, but we also make them increasingly available as feature toggle. Which makes our list of feature toggles at some point fairly large.
Not saying that we shouldn't introduce this one - just noting that we make excessive use of it lately.
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/rdb/RDBDocumentNodeStoreBuilder.java:
##########
@@ -138,4 +138,26 @@ public RDBDocumentNodeStoreBuilder setDocStoreDetailedGCFeature(@Nullable Featur
public Feature getDocStoreDetailedGCFeature() {
return null;
}
+
+ @Override
+ public boolean isEmbeddedVerificationEnabled() {
+ return false;
Review Comment:
what was again the reason why detailedGC is not supported for RDB?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10633 : make embedded verification configurable in detailedGC [jackrabbit-oak]
Posted by "rishabhdaim (via GitHub)" <gi...@apache.org>.
rishabhdaim merged PR #1294:
URL: https://github.com/apache/jackrabbit-oak/pull/1294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10633 : make embedded verification configurable in detailedGC [jackrabbit-oak]
Posted by "stefan-egli (via GitHub)" <gi...@apache.org>.
stefan-egli commented on code in PR #1294:
URL: https://github.com/apache/jackrabbit-oak/pull/1294#discussion_r1479611977
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/rdb/RDBDocumentNodeStoreBuilder.java:
##########
@@ -138,4 +138,26 @@ public RDBDocumentNodeStoreBuilder setDocStoreDetailedGCFeature(@Nullable Featur
public Feature getDocStoreDetailedGCFeature() {
return null;
}
+
+ @Override
+ public boolean isEmbeddedVerificationEnabled() {
+ return false;
Review Comment:
thx - (I think we also introduced a new method to DocumentStore that DetailedGC requires)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org