[GitHub] zheng-da commented on a change in pull request #11498: Fix InferStorage for sparse fallback in FullyConnected

[GitBox <gi...@apache.org>]

zheng-da commented on a change in pull request #11498: Fix InferStorage for sparse fallback in FullyConnected
URL: https://github.com/apache/incubator-mxnet/pull/11498#discussion_r199313642
 
 

 ##########
 File path: src/operator/nn/fully_connected.cc
 ##########
 @@ -210,17 +210,17 @@ inline static bool BackwardFCStorageType(const nnvm::NodeAttrs& attrs,
   CHECK_EQ(in_attrs->size(), 3U);
   CHECK_EQ(out_attrs->size(), out_expected);
 
-  DispatchMode wanted_mode;
-#if 0
+  bool dispatched = false;
   // TODO(zhengda) let's disable MKLDNN for FullyConnected for now.
 
 Review comment:
   ideally we should enable it. i forgot the case that it fails. i don't think MKLDNN FC backward is much faster than our native implementation. so it's not very urgent.
   @pengzhao-intel @TaoLv did you check if MKLDNN FC backward works in all cases?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services