[jira] [Comment Edited] (HBASE-10014) HRegion#doMiniBatchMutation rollbacks the memstore even if there is nothing to rollback.

["Anoop Sam John (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-10014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13828482#comment-13828482 ] 

Anoop Sam John edited comment on HBASE-10014 at 11/21/13 4:30 AM:
------------------------------------------------------------------

bq.+    boolean doRollBackMemstore = false;
{quote}
       if (walEdit.size() > 0) \{
         syncOrDefer(txid, durability);
       \}
\-      walSyncSuccessful = true;
+      doRollBackMemstore = false;
{quote}
When a sync call on WAL is failed, we should be doing the rollback. Now wont be doing that as we have initialized doRollBackMemstore  to false.  We should initialize this to true.



was (Author: anoop.hbase):
bq.+    boolean doRollBackMemstore = false;
{quote}
       if (walEdit.size() > 0) {
         syncOrDefer(txid, durability);
       }
-      walSyncSuccessful = true;
+      doRollBackMemstore = false;
{quote}
When a sync call on WAL is failed, we should be doing the rollback. Now wont be doing that as we have initialized doRollBackMemstore  to false.  We should initialize this to true.


> HRegion#doMiniBatchMutation rollbacks the memstore even if there is nothing to rollback.
> ----------------------------------------------------------------------------------------
>
>                 Key: HBASE-10014
>                 URL: https://issues.apache.org/jira/browse/HBASE-10014
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.98.0, 0.96.0, 0.94.13
>            Reporter: Nicolas Liochon
>            Assignee: Nicolas Liochon
>             Fix For: 0.98.0, 0.96.1, 0.94.15
>
>         Attachments: 10014.patch
>
>
> See HBASE-10001



--
This message was sent by Atlassian JIRA
(v6.1#6144)