You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by jorgebay <gi...@git.apache.org> on 2018/04/23 13:15:29 UTC
[GitHub] tinkerpop pull request #852: TINKERPOP-1944 Export DriverRemoteConnection
GitHub user jorgebay opened a pull request:
https://github.com/apache/tinkerpop/pull/852
TINKERPOP-1944 Export DriverRemoteConnection
Export `DriverRemoteConnection`.
https://issues.apache.org/jira/browse/TINKERPOP-1944
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1944
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/852.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #852
----
commit d037ef7049f36410caba9362bd60cb8dfc04f857
Author: Jorge Bay Gondra <jo...@...>
Date: 2018-04-23T13:13:32Z
TINKERPOP-1944 Export DriverRemoteConnection
----
---
[GitHub] tinkerpop issue #852: TINKERPOP-1944 Export DriverRemoteConnection
Posted by jbmusso <gi...@git.apache.org>.
Github user jbmusso commented on the issue:
https://github.com/apache/tinkerpop/pull/852
VOTE +1
---
[GitHub] tinkerpop issue #852: TINKERPOP-1944 Export DriverRemoteConnection
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/852
VOTE: +1
---
[GitHub] tinkerpop issue #852: TINKERPOP-1944 Export DriverRemoteConnection
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/852
VOTE +1
---
[GitHub] tinkerpop issue #852: TINKERPOP-1944 Export DriverRemoteConnection
Posted by aaronjwood <gi...@git.apache.org>.
Github user aaronjwood commented on the issue:
https://github.com/apache/tinkerpop/pull/852
Can the docs be fixed surrounding this as well? The docs show:
```
const graph = new Graph();
const g = graph.traversal().withRemote(new DriverRemoteConnection('ws://localhost:8182/gremlin'));
```
which doesn't match up at all with what you really need to do: https://groups.google.com/d/msg/gremlin-users/YyHXS579cyw/t3TnQG_BAgAJ
The concept of importing the module and showing where to access these classes (`gremlin.driver` or `gremlin.structure` for example) is missing, which will make people have to hunt down where the classes really are.
---
[GitHub] tinkerpop issue #852: TINKERPOP-1944 Export DriverRemoteConnection
Posted by aaronjwood <gi...@git.apache.org>.
Github user aaronjwood commented on the issue:
https://github.com/apache/tinkerpop/pull/852
I ran into this issue earlier today but hit another one once I had exported this myself in my local copy of the library: https://groups.google.com/forum/#!topic/gremlin-users/YyHXS579cyw
To sum it up, when using `DriverRemoteConnection` an error is thrown about an invalid OpProcessor being used:
```
Error: Server error (no request information): Invalid OpProcessor requested [null] (499)
at Object.keys.forEach.requestId (/Users/woodaaron/Code/src/api-gw/node_modules/gremlin/lib/driver/driver-remote-connection.js:137:15)
at Array.forEach (<anonymous>)
at DriverRemoteConnection._handleMessage (/Users/woodaaron/Code/src/api-gw/node_modules/gremlin/lib/driver/driver-remote-connection.js:132:45)
at WebSocket.DriverRemoteConnection._ws.on.data (/Users/woodaaron/Code/src/api-gw/node_modules/gremlin/lib/driver/driver-remote-connection.js:68:41)
at WebSocket.emit (events.js:180:13)
at Receiver._receiver.onmessage (/Users/woodaaron/Code/src/api-gw/node_modules/gremlin/node_modules/ws/lib/WebSocket.js:141:47)
at Receiver.dataMessage (/Users/woodaaron/Code/src/api-gw/node_modules/gremlin/node_modules/ws/lib/Receiver.js:380:14)
at Receiver.getData (/Users/woodaaron/Code/src/api-gw/node_modules/gremlin/node_modules/ws/lib/Receiver.js:330:12)
at Receiver.startLoop (/Users/woodaaron/Code/src/api-gw/node_modules/gremlin/node_modules/ws/lib/Receiver.js:165:16)
at Receiver.add (/Users/woodaaron/Code/src/api-gw/node_modules/gremlin/node_modules/ws/lib/Receiver.js:139:10)
```
---
[GitHub] tinkerpop pull request #852: TINKERPOP-1944 Export DriverRemoteConnection
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/852
---