[GitHub] [flink] morhidi commented on a diff in pull request #19844: [FLINK-27805][Connectors/ORC] bump orc version to 1.7.5

[GitBox <gi...@apache.org>]

morhidi commented on code in PR #19844:
URL: https://github.com/apache/flink/pull/19844#discussion_r926653959


##########
flink-formats/flink-orc/src/test/java/org/apache/flink/orc/writer/OrcBulkWriterTest.java:
##########
@@ -46,16 +57,8 @@ public class OrcBulkWriterTest {
     private final List<Record> input =
             Arrays.asList(new Record("Shiv", 44), new Record("Jesse", 23), new Record("Walt", 50));
 
-    @Test
-    public void testOrcBulkWriter() throws Exception {
-        final File outDir = TEMPORARY_FOLDER.newFolder();
-        final Properties writerProps = new Properties();
-        writerProps.setProperty("orc.compress", "LZ4");
-
-        final OrcBulkWriterFactory<Record> writer =
-                new OrcBulkWriterFactory<>(
-                        new RecordVectorizer(schema), writerProps, new Configuration());
-
+    private void writeRecordsIntoOrcFile(File outDir, OrcBulkWriterFactory<Record> writer)

Review Comment:
   nit: Can we move this method after the ones using them?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org