You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2019/07/29 18:55:27 UTC
[GitHub] [incubator-iceberg] sujithjay commented on a change in pull request
#327: Introduce startsWith Predicate
sujithjay commented on a change in pull request #327: Introduce startsWith Predicate
URL: https://github.com/apache/incubator-iceberg/pull/327#discussion_r308383537
##########
File path: api/src/main/java/org/apache/iceberg/transforms/Bucket.java
##########
@@ -113,6 +116,7 @@ public String toString() {
predicate.op(), name, apply(predicate.literal().value()));
// case IN:
// return Expressions.predicate();
+ case STARTS_WITH:
Review comment:
I am not sure if a `startsWith` predicate makes sense in case of `Bucket` transforms. Hence, leaving it to be handled by the `default` case. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org