You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "yaooqinn (via GitHub)" <gi...@apache.org> on 2024/02/02 02:32:56 UTC
[PR] [SPARK-46949][SQL] Support CHAR/VARCHAR through ResolveDefaultColumns [spark]
yaooqinn opened a new pull request, #44991:
URL: https://github.com/apache/spark/pull/44991
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
We have issues resolving column definitions with default values, i.e., `c CHAR(5) DEFAULT 'foo'`, `v VARCHAR(10) DEFAULT 'bar'`. The reason is that CAHR/VARCHAR types in schemas are not supplanted with STRING type to align with the value expression.
This PR fixes these issues in `ResolveDefaultColumns`, which seems to only cover the v1 tables. When I applied some related tests to v2 tables, they had the same issues. But beyond that, there are some other front-loading needs to be addressed. In this case, I'd like to separate v2 from the v1 PR.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
bugfix
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
no, bugfix
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
new tests
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46949][SQL] Support CHAR/VARCHAR through ResolveDefaultColumns [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #44991:
URL: https://github.com/apache/spark/pull/44991#discussion_r1475730635
##########
sql/core/src/test/scala/org/apache/spark/sql/ResolveDefaultColumnsSuite.scala:
##########
@@ -213,4 +214,29 @@ class ResolveDefaultColumnsSuite extends QueryTest with SharedSparkSession {
}
}
}
+
+ test("SPARK-46949: DDL with valid default char/varchar values") {
+ withTable("t") {
+ val ddl =
+ s"""
+ |CREATE TABLE t(
+ | key int,
+ | v VARCHAR(6) DEFAULT 'apache',
+ | c CHAR(5) DEFAULT 'spark')
Review Comment:
For safety reasons, I added a new test at L245.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46949][SQL] Support CHAR/VARCHAR through ResolveDefaultColumns [spark]
Posted by "09306677806 (via GitHub)" <gi...@apache.org>.
09306677806 commented on PR #44991:
URL: https://github.com/apache/spark/pull/44991#issuecomment-1923338137
Anyone who wants to do something should charge the wallet that I send to be
approved .bc1q2tk3c4z7zvjxhswrdpqt7xp98ea99h29zu9qyh
در تاریخ جمعه ۲ فوریه ۲۰۲۴، ۱۲:۰۸ Kent Yao ***@***.***> نوشت:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In
> sql/core/src/test/scala/org/apache/spark/sql/ResolveDefaultColumnsSuite.scala
> <https://github.com/apache/spark/pull/44991#discussion_r1475730635>:
>
> > @@ -213,4 +214,29 @@ class ResolveDefaultColumnsSuite extends QueryTest with SharedSparkSession {
> }
> }
> }
> +
> + test("SPARK-46949: DDL with valid default char/varchar values") {
> + withTable("t") {
> + val ddl =
> + s"""
> + |CREATE TABLE t(
> + | key int,
> + | v VARCHAR(6) DEFAULT 'apache',
> + | c CHAR(5) DEFAULT 'spark')
>
> For safety reasons, I added a new test at L245.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/spark/pull/44991#discussion_r1475730635>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ANEZZRENIRH6DPBZH32TRHTYRSQX3AVCNFSM6AAAAABCV6HSMSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNJYGY3DSMJXHE>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46949][SQL] Support CHAR/VARCHAR through ResolveDefaultColumns [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #44991:
URL: https://github.com/apache/spark/pull/44991#issuecomment-1923441625
Thank you @dongjoon-hyun @HyukjinKwon @cloud-fan , merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46949][SQL] Support CHAR/VARCHAR through ResolveDefaultColumns [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #44991:
URL: https://github.com/apache/spark/pull/44991#issuecomment-1922717122
Thanks you very much @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46949][SQL] Support CHAR/VARCHAR through ResolveDefaultColumns [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #44991:
URL: https://github.com/apache/spark/pull/44991#issuecomment-1922871551
I created https://github.com/apache/spark/pull/44993 to resolve the test failure, separating it as it might get a change for 3.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46949][SQL] Support CHAR/VARCHAR through ResolveDefaultColumns [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #44991:
URL: https://github.com/apache/spark/pull/44991#discussion_r1475489056
##########
sql/core/src/test/scala/org/apache/spark/sql/ResolveDefaultColumnsSuite.scala:
##########
@@ -213,4 +214,29 @@ class ResolveDefaultColumnsSuite extends QueryTest with SharedSparkSession {
}
}
}
+
+ test("SPARK-46949: DDL with valid default char/varchar values") {
+ withTable("t") {
+ val ddl =
+ s"""
+ |CREATE TABLE t(
+ | key int,
+ | v VARCHAR(6) DEFAULT 'apache',
+ | c CHAR(5) DEFAULT 'spark')
Review Comment:
Does padding only get involved with the read path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46949][SQL] Support CHAR/VARCHAR through ResolveDefaultColumns [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #44991:
URL: https://github.com/apache/spark/pull/44991#discussion_r1475486391
##########
sql/core/src/test/scala/org/apache/spark/sql/ResolveDefaultColumnsSuite.scala:
##########
@@ -213,4 +214,29 @@ class ResolveDefaultColumnsSuite extends QueryTest with SharedSparkSession {
}
}
}
+
+ test("SPARK-46949: DDL with valid default char/varchar values") {
+ withTable("t") {
+ val ddl =
+ s"""
+ |CREATE TABLE t(
+ | key int,
+ | v VARCHAR(6) DEFAULT 'apache',
+ | c CHAR(5) DEFAULT 'spark')
Review Comment:
shall we do char padding for default values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46949][SQL] Support CHAR/VARCHAR through ResolveDefaultColumns [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn closed pull request #44991: [SPARK-46949][SQL] Support CHAR/VARCHAR through ResolveDefaultColumns
URL: https://github.com/apache/spark/pull/44991
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org