You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "korowa (via GitHub)" <gi...@apache.org> on 2023/03/07 14:07:33 UTC

[GitHub] [arrow-datafusion] korowa commented on a diff in pull request #5491: feat: interval add timestamp

korowa commented on code in PR #5491:
URL: https://github.com/apache/arrow-datafusion/pull/5491#discussion_r1127916406


##########
datafusion/core/tests/sqllogictests/test_files/timestamps.slt:
##########
@@ -191,3 +191,24 @@ query P
 SELECT DATE_TRUNC('second', '2022-08-03 14:38:50Z');
 ----
 2022-08-03T14:38:50
+
+# Test that interval can add a timestamp

Review Comment:
   Thank you!
   
   I also suppose it's worth adding tests for `interval + timestamp` case, as it was added in scalar.rs



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org