You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "eirv (via GitHub)" <gi...@apache.org> on 2026/01/21 14:05:00 UTC

[PR] Fix ClassNotFoundException message variable [commons-lang]

eirv opened a new pull request, #1577:
URL: https://github.com/apache/commons-lang/pull/1577

   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       https://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for your contribution to [Apache Commons](https://commons.apache.org/)! Your help is appreciated!
   
   Before you push a pull request, review this list:
   
   - [ ] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
   - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI).
   - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
   - [ ] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself.
   - [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
   - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [ ] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix ClassNotFoundException message in ClassUtils.getClass(String) [commons-lang]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #1577:
URL: https://github.com/apache/commons-lang/pull/1577#issuecomment-3786331407

   @eirv 
   Thank you for your contribution, merged! 🚀 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix ClassNotFoundException message variable [commons-lang]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #1577:
URL: https://github.com/apache/commons-lang/pull/1577#issuecomment-3780812259

   Please add a unit test to avoid regression and proce that this actually fixes something. It's not clear to me it does since we show which class is really missing without the extra syntax we support here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix ClassNotFoundException message variable [commons-lang]

Posted by "eirv (via GitHub)" <gi...@apache.org>.
eirv commented on PR #1577:
URL: https://github.com/apache/commons-lang/pull/1577#issuecomment-3784555885

   > Hello @eirv
   > 
   > Regardless of the argument, please add tests to demonstrate the intent and prevent regressions in the future. This will make it clear what the actual goal and implications are.
   
   Okay, I've finished writing the unit test code. Please review my next commit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix ClassNotFoundException message variable [commons-lang]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #1577:
URL: https://github.com/apache/commons-lang/pull/1577


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix ClassNotFoundException message variable [commons-lang]

Posted by "eirv (via GitHub)" <gi...@apache.org>.
eirv commented on PR #1577:
URL: https://github.com/apache/commons-lang/pull/1577#issuecomment-3781416106

   > Please add a unit test to avoid regression and proce that this actually fixes something. It's not clear to me it does since we show which class is really missing without the extra syntax we support here.
   
   The `next` variable gets modified during the transformation process (dots to dollar signs for inner classes), so using className preserves the original requested class name in the error message, making it more useful for debugging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org