[GitHub] [incubator-iceberg] waterlx commented on a change in pull request #719: Route to Hadoop table more strictly in IcebergSource#getTable()

[GitBox <gi...@apache.org>]

waterlx commented on a change in pull request #719: Route to Hadoop table more strictly in IcebergSource#getTable()
URL: https://github.com/apache/incubator-iceberg/pull/719#discussion_r361908519
 
 

 ##########
 File path: spark/src/main/java/org/apache/iceberg/spark/source/IcebergSource.java
 ##########
 @@ -149,6 +149,12 @@ protected Table findTable(DataSourceOptions options, Configuration conf) {
     }
   }
 
+  private boolean routeToHadoopTable(final String path) {
 
 Review comment:
   I thought path = "db.tab/le" (table name or db name contains "/") might be better to be routed to Hive table instead of Hadoop table (as the current logic). But as I tried, Hive do not allow us to create a db or a table with "/" in its name. This PR seems not necessary.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org