You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/01/07 02:00:28 UTC
[GitHub] [iotdb] yuqi1129 commented on a change in pull request #2435: Optimize enum class and change some java practice
yuqi1129 commented on a change in pull request #2435:
URL: https://github.com/apache/iotdb/pull/2435#discussion_r553065056
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/memtable/AbstractMemTable.java
##########
@@ -174,10 +175,11 @@ public void write(InsertTabletPlan insertTabletPlan, int start, int end) {
@Override
public boolean checkIfChunkDoesNotExist(String deviceId, String measurement) {
- if (!memTableMap.containsKey(deviceId)) {
+ Map<String, IWritableMemChunk> memSeries = memTableMap.get(deviceId);
+ if (null == memSeries) {
return true;
}
- Map<String, IWritableMemChunk> memSeries = memTableMap.get(deviceId);
+
Review comment:
> else return false?
Sorry, i can't figure your meaning, can you make it more clear?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org