[GitHub] squito commented on a change in pull request #22806: [SPARK-25250][CORE] : Late zombie task completions handled correctly even before new taskset launched

[GitBox <gi...@apache.org>]

squito commented on a change in pull request #22806: [SPARK-25250][CORE] : Late zombie task completions handled correctly even before new taskset launched
URL: https://github.com/apache/spark/pull/22806#discussion_r258677803
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
 ##########
 @@ -1383,6 +1383,7 @@ private[spark] class DAGScheduler(
 
     event.reason match {
       case Success =>
+        taskScheduler.markPartitionCompletedFromEventLoop(task.partitionId, task.stageId)
 
 Review comment:
   @pgandhi999 I don't follow your explanation -- I think I agree w/ @Ngone51 .  yes, TSM calls `DAGs.taskEnded` while it has a lock on the TaskSchedulerImpl, but the `DAGs.taskEnded` call just puts an event into the queue and then returns.  So this part is happening w/ out the lock.  but maybe you meant something else?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org