You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "slachiewicz (via GitHub)" <gi...@apache.org> on 2026/08/06 00:22:57 UTC
[PR] Keep Markdown headings from being read as Velocity comments [maven-doxia-sitetools]
slachiewicz opened a new pull request, #664:
URL: https://github.com/apache/maven-doxia-sitetools/pull/664
A Markdown ATX heading below level one starts with ##, which is also how a
Velocity line comment starts. In a *.md.vm document Velocity strips the
heading before Doxia ever sees it, so the whole line disappears from the
rendered page with no error and no warning.
Pages in the wild hit this today, among them maven-release-plugin's usage
and migrate pages, maven-checkstyle-plugin's history page and
maven-scm-plugin's scm-advance-features page: every subsection heading they
declare is missing from the published site.
Such lines are now wrapped in Velocity's unparsed block #[[ ... ]]# before
evaluation. Only a document that actually contains one is rewritten, and
only when it is parsed as Markdown, so every document rendering correctly
today still goes through mergeTemplate unchanged.
A doubled hash further along a line is left alone: there it really is a
Velocity comment, and Markdown gives it no meaning.
Part of the wider migration tracked in
https://github.com/apache/maven-doxia-converter/issues/139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Keep Markdown headings from being read as Velocity comments [maven-doxia-sitetools]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #664:
URL: https://github.com/apache/maven-doxia-sitetools/pull/664#issuecomment-5306959271
Superseded by #675 — same commit, rebased onto current master, on a branch in this repository so the fork can be removed.
*This comment was created with AI assistance.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Keep Markdown headings from being read as Velocity comments [maven-doxia-sitetools]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz closed pull request #664: Keep Markdown headings from being read as Velocity comments
URL: https://github.com/apache/maven-doxia-sitetools/pull/664
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org