You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "rich7420 (via GitHub)" <gi...@apache.org> on 2025/12/12 02:01:46 UTC
[PR] [QDP] improve e2e benchmark [mahout]
rich7420 opened a new pull request, #713:
URL: https://github.com/apache/mahout/pull/713
### Purpose of PR
<!-- Describe what this PR does. -->
- cleaning the cache and sync cuda
- let timer at same scope
### Related Issues or PRs
<!-- Add links to related issues or PRs. -->
<!-- - Closes #123 -->
<!-- - Related to #123 -->
Closes #695
### Changes Made
<!-- Please mark one with an "x" -->
- [ ] Bug fix
- [ ] New feature
- [ ] Refactoring
- [ ] Documentation
- [x] Test
- [ ] CI/CD pipeline
- [ ] Other
### Breaking Changes
<!-- Does this PR introduce a breaking change? -->
- [ ] Yes
- [x] No
### Checklist
<!-- Please mark each item with an "x" when complete -->
<!-- If not all items are complete, please open this as a **Draft PR**.
Once all requirements are met, mark as ready for review. -->
- [ ] Added or updated unit tests for all changes
- [ ] Added or updated documentation for all changes
- [x] Successfully built and ran all unit tests or manual tests locally
- [ ] PR title follows "MAHOUT-XXX: Brief Description" format (if related to an issue)
- [ ] Code follows ASF guidelines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [QDP] improve e2e benchmark [mahout]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming merged PR #713:
URL: https://github.com/apache/mahout/pull/713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [QDP] improve e2e benchmark [mahout]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on code in PR #713:
URL: https://github.com/apache/mahout/pull/713#discussion_r2613120593
##########
qdp/benchmark/benchmark_e2e.py:
##########
@@ -63,6 +64,14 @@
BATCH_SIZE = 64 # Small batch to stress loop overhead
+def clean_cache():
Review Comment:
Let's call `gc.collect()` before `torch.cuda.empty_cache()` because tensors must be freed by Python first for the CUDA cache clear to actually release memory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [QDP] improve e2e benchmark [mahout]
Posted by "rich7420 (via GitHub)" <gi...@apache.org>.
rich7420 commented on code in PR #713:
URL: https://github.com/apache/mahout/pull/713#discussion_r2613252036
##########
qdp/benchmark/benchmark_e2e.py:
##########
@@ -63,6 +64,14 @@
BATCH_SIZE = 64 # Small batch to stress loop overhead
+def clean_cache():
Review Comment:
you're right. thanks for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org