a couple of bugs and new functionalities

[Massimo Manghi <ma...@unipr.it>]

On the bug tracking system ther's a debate about a couple of glitches 
Jeff Lawson
found in Rivet. One of them spurred the idea of extending the 'makeurl' 
command
to make it a bit more flexible.

In my view the command should be accepting a variable number of 
arguments
and be able to process the to build a complete URL

puts [makeurl a b c d]

=> http://myhost[:port]/a/b/c/d

makeurl should also check for a '?' in the variable length list and 
treat
elements past this element (if existing) as a even length sublist from
which pairs of <parameters>-<values> can be built

puts [makeurl a b c ? arg1 val1 arg2 val2 ...]

Jeff is leaning towards the idea that makeurl should resolve relative 
paths using
the SCRIPT_NAME environment variable to create fully qualified URLs to 
be used
outside the context of a page referer (browsers resolve quite well 
relative paths
on their own)


Another issue came from the scope resolution chosen for the commands
'load_env' and 'load_headers' which accept an array name as argument.
CUrrently the scope resolution is determined by the TCL_NAMESPACE_ONLY
flag in Tcl_ObjSetVar2. This flag rules out the possibility of creating
the array within the local variables of a procedure. Even though
creating and the destroying a whole array in a procedure call implies 
some
overhead we don't see why it shouldn't be possible, so I provided a 
patch
for rivetCore.c and TclWebapache.c that reset the flags to normal scope
resolution. We are testing it and patches are available on Bugzilla

  thank you Jeff for having resumed Bugzilla as a way to document bugs, 
it's
something we could benefit from. Good idea.

  -- Massimo


---------------------------------------------------------------------
To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: rivet-dev-help@tcl.apache.org

Re: a couple of bugs and new functionalities

[Massimo Manghi <ma...@unipr.it>]

On Mon, 29 Aug 2011 21:48:45 +0100, Massimo Manghi wrote:
> On Mon, 29 Aug 2011 10:36:11 -0500, Jeff Lawson wrote:
>> For those wanting to follow along, the relevant bugs are:
>>
>> https://issues.apache.org/bugzilla/show_bug.cgi?id=48963 [4]
>> https://issues.apache.org/bugzilla/show_bug.cgi?id=51723 [5]
>
>
patches for both bugs have been posted on bugzilla for anyone
to test them. I will allow a few more days before committing
these changes.

  -- Massimo

---------------------------------------------------------------------
To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: rivet-dev-help@tcl.apache.org

Re: a couple of bugs and new functionalities

[Massimo Manghi <ma...@unipr.it>]

On Mon, 29 Aug 2011 10:36:11 -0500, Jeff Lawson wrote:
> For those wanting to follow along, the relevant bugs are:
>
> https://issues.apache.org/bugzilla/show_bug.cgi?id=48963 [4]
> https://issues.apache.org/bugzilla/show_bug.cgi?id=51723 [5]

which are 2 of the 3 bugs opened on Bugzilla against Rivet :-) being
the third bug concerning the build system and it has been closed
a few minutes ago.

>
> The first one had actually been open for a year and a half :)
>

Sorry, I overlooked it completely, probably because bugzilla had
slipped out of our habits completely and because when you filed it
I was busy trying to release Rivet 2.0.0.
Perhaps I took the message as coming from one of the Debian lists
regarding Tcl/Tk related packages.

"Repetita juvant" used to say the ancient Romans: "repetitions help"

  -- Massimo



---------------------------------------------------------------------
To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: rivet-dev-help@tcl.apache.org

Re: a couple of bugs and new functionalities

[Jeff Lawson <je...@bovine.net>]

For those wanting to follow along, the relevant bugs are:

https://issues.apache.org/bugzilla/show_bug.cgi?id=48963
https://issues.apache.org/bugzilla/show_bug.cgi?id=51723

The first one had actually been open for a year and a half :)


2011/8/29 Massimo Manghi <ma...@unipr.it>

> On the bug tracking system ther's a debate about a couple of glitches Jeff
> Lawson
> found in Rivet. One of them spurred the idea of extending the 'makeurl'
> command
> to make it a bit more flexible.
>
> In my view the command should be accepting a variable number of arguments
> and be able to process the to build a complete URL
>
> puts [makeurl a b c d]
>
> => http://myhost[:port]/a/b/c/d
>
> makeurl should also check for a '?' in the variable length list and treat
> elements past this element (if existing) as a even length sublist from
> which pairs of <parameters>-<values> can be built
>
> puts [makeurl a b c ? arg1 val1 arg2 val2 ...]
>
> Jeff is leaning towards the idea that makeurl should resolve relative paths
> using
> the SCRIPT_NAME environment variable to create fully qualified URLs to be
> used
> outside the context of a page referer (browsers resolve quite well relative
> paths
> on their own)
>
>
> Another issue came from the scope resolution chosen for the commands
> 'load_env' and 'load_headers' which accept an array name as argument.
> CUrrently the scope resolution is determined by the TCL_NAMESPACE_ONLY
> flag in Tcl_ObjSetVar2. This flag rules out the possibility of creating
> the array within the local variables of a procedure. Even though
> creating and the destroying a whole array in a procedure call implies some
> overhead we don't see why it shouldn't be possible, so I provided a patch
> for rivetCore.c and TclWebapache.c that reset the flags to normal scope
> resolution. We are testing it and patches are available on Bugzilla
>
>  thank you Jeff for having resumed Bugzilla as a way to document bugs, it's
> something we could benefit from. Good idea.
>
>  -- Massimo
>
>
> ------------------------------**------------------------------**---------
> To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.**apache.org<ri...@tcl.apache.org>
> For additional commands, e-mail: rivet-dev-help@tcl.apache.org
>
>